[Extensions] Update extensions UI to observe events and add test

chrome/browser/ui/webui/extensions/extension_settings_browsertest.cc

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/extensions/extension_settings_browsertest.h"
 
 #include "base/files/file_path.h"
 #include "base/path_service.h"
 #include "base/strings/string_number_conversions.h"
 #include "chrome/browser/chrome_notification_types.h"
 #include "chrome/browser/extensions/crx_installer.h"
 #include "chrome/browser/extensions/extension_error_reporter.h"
 #include "chrome/browser/extensions/extension_install_prompt.h"
 #include "chrome/browser/extensions/extension_install_prompt_show_params.h"
 #include "chrome/browser/extensions/extension_service.h"
 #include "chrome/browser/extensions/unpacked_installer.h"
 #include "chrome/browser/profiles/profile.h"
 #include "chrome/browser/profiles/profile_manager.h"
 #include "chrome/browser/ui/browser.h"
 #include "chrome/browser/ui/tabs/tab_strip_model.h"
 #include "chrome/common/chrome_paths.h"
 #include "content/public/browser/notification_registrar.h"
 #include "content/public/browser/notification_service.h"
 #include "content/public/browser/render_view_host.h"
 #include "content/public/test/browser_test_utils.h"
 #include "content/public/test/test_utils.h"
+#include "extensions/browser/api/management/management_api.h"
 #include "extensions/browser/extension_registry.h"
 #include "extensions/browser/extension_system.h"
 #include "extensions/browser/test_extension_registry_observer.h"
 #include "extensions/common/extension_set.h"
 
 using extensions::Extension;
 using extensions::TestManagementPolicyProvider;
 
 ExtensionSettingsUIBrowserTest::ExtensionSettingsUIBrowserTest()
     : profile_(NULL),
       policy_provider_(TestManagementPolicyProvider::PROHIBIT_MODIFY_STATUS |
                        TestManagementPolicyProvider::MUST_REMAIN_ENABLED |
-                       TestManagementPolicyProvider::MUST_REMAIN_INSTALLED) {}
+                       TestManagementPolicyProvider::MUST_REMAIN_INSTALLED) {
+  CHECK(PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir_));
+  test_data_dir_ = test_data_dir_.AppendASCII("extensions");
+}
 
 ExtensionSettingsUIBrowserTest::~ExtensionSettingsUIBrowserTest() {}
 
 Profile* ExtensionSettingsUIBrowserTest::GetProfile() {
   if (!profile_) {
     profile_ = browser() ? browser()->profile() :
                            ProfileManager::GetActiveUserProfile();
   }
   return profile_;
 }
 
 void ExtensionSettingsUIBrowserTest::SetUpOnMainThread() {
   WebUIBrowserTest::SetUpOnMainThread();
   observer_.reset(new ExtensionTestNotificationObserver(browser()));
 }
 
 void ExtensionSettingsUIBrowserTest::InstallGoodExtension() {
-  base::FilePath test_data_dir;
-  if (!PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)) {
-    ADD_FAILURE();
-    return;
-  }
-  base::FilePath extensions_data_dir = test_data_dir.AppendASCII("extensions");
-  EXPECT_TRUE(InstallExtension(extensions_data_dir.AppendASCII("good.crx")));
+  EXPECT_TRUE(InstallExtension(test_data_dir_.AppendASCII("good.crx")));
 }
 
 void ExtensionSettingsUIBrowserTest::InstallErrorsExtension() {
-  base::FilePath test_data_dir;
-  if (!PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir)) {
-    ADD_FAILURE();
-    return;
-  }
-  base::FilePath extensions_data_dir = test_data_dir.AppendASCII("extensions");
-  extensions_data_dir = extensions_data_dir.AppendASCII("error_console");
   EXPECT_TRUE(InstallUnpackedExtension(
-      extensions_data_dir.AppendASCII("runtime_and_manifest_errors"),
-      "pdlpifnclfacjobnmbpngemkalkjamnf"));
+      test_data_dir_.AppendASCII("error_console")
+                    .AppendASCII("runtime_and_manifest_errors")));
 }
 
 void ExtensionSettingsUIBrowserTest::AddManagedPolicyProvider() {
   auto* extension_service = extensions::ExtensionSystem::Get(GetProfile());
   extension_service->management_policy()->RegisterProvider(&policy_provider_);
 }
 
+void ExtensionSettingsUIBrowserTest::SetAutoConfirmUninstall() {
+  extensions::ManagementUninstallFunctionBase::SetAutoConfirmForTest(true);
+}
+
+void ExtensionSettingsUIBrowserTest::InstallSharedModule() {
+  base::FilePath shared_module_path =
+      test_data_dir_.AppendASCII("api_test").AppendASCII("shared_module");
+  EXPECT_TRUE(InstallUnpackedExtension(
+      shared_module_path.AppendASCII("shared")));
+  EXPECT_TRUE(InstallUnpackedExtension(
+      shared_module_path.AppendASCII("import_pass")));
+}
+
 class MockAutoConfirmExtensionInstallPrompt : public ExtensionInstallPrompt {
  public:
   explicit MockAutoConfirmExtensionInstallPrompt(
       content::WebContents* web_contents)
     : ExtensionInstallPrompt(web_contents) {}
 
   // Proceed without confirmation prompt.
   void ConfirmInstall(Delegate* delegate,
                       const Extension* extension,
                       const ShowDialogCallback& show_dialog_callback) override {
     delegate->InstallUIProceed();
   }
 };
 
 const Extension* ExtensionSettingsUIBrowserTest::InstallUnpackedExtension(
-    const base::FilePath& path, const char* id) {
+    const base::FilePath& path) {
   if (path.empty())
     return NULL;
 
   Profile* profile = GetProfile();
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   service->set_show_extensions_prompts(false);
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(profile);
-  extensions::TestExtensionRegistryObserver observer(registry, id);
+  extensions::TestExtensionRegistryObserver observer(registry);
+  extensions::UnpackedInstaller::Create(service)->Load(path);
+  base::FilePath extension_path = base::MakeAbsoluteFilePath(path);
+  const Extension* extension = nullptr;
+  do {
+    extension = observer.WaitForExtensionLoaded();

[Dan Beam, 2015/04/01 23:12:04]

can this return nullptr?

[Devlin, 2015/04/02 00:01:38]

Nope.

+  } while (extension->path() != extension_path);
 
-  extensions::UnpackedInstaller::Create(service)->Load(path);
-
-  // Test will timeout if extension is not loaded.
-  observer.WaitForExtensionLoaded();
-  return service->GetExtensionById(last_loaded_extension_id(), false);
+  return extension;
 }
 
 const Extension* ExtensionSettingsUIBrowserTest::InstallExtension(
     const base::FilePath& path) {
   Profile* profile = GetProfile();
   ExtensionService* service =
       extensions::ExtensionSystem::Get(profile)->extension_service();
   extensions::ExtensionRegistry* registry =
       extensions::ExtensionRegistry::Get(profile);
   service->set_show_extensions_prompts(false);
@@ skipping 43 matching lines @@
          iter != errors->end(); ++iter)
       VLOG(1) << *iter;
 
     return NULL;
   }
 
   if (!observer_->WaitForExtensionViewsToLoad())
     return NULL;
   return service->GetExtensionById(last_loaded_extension_id(), false);
 }