[Extensions] Update extensions UI to observe events and add test

chrome/browser/ui/webui/extensions/extension_settings_browsertest.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(dbeam): test for loading upacked extensions?
 
 GEN('#include "chrome/browser/ui/webui/extensions/' +
     'extension_settings_browsertest.h"');
 
 // chrome/test/data/extensions/good.crx's extension ID. good.crx is loaded by
@@ skipping 73 matching lines @@
     assertTrue(this.steps.length > 0);
     this.steps.shift().call(this);
   },
 
   /** @protected */
   waitForPageLoad: function() {
     var extensionList = getRequiredElement('extension-settings-list');
     extensionList.extensionsUpdated_.then(this.nextStep.bind(this));
   },
 
-  /**
-   * A silly hack because we re-fetch extension data after every event, which is
-   * asynchronous. This will be unneeded once we transition to observing events
-   * on the developerPrivate API.
-   * @param {Function} after The function to run after the pending requests.
-   * @protected
-   */
-  runPendingRequests: function(after) {
-    window.setTimeout(function() {
-      chrome.developerPrivate.getExtensionsInfo(after);
-    }, 0);
-  },
-
   /** @protected */
   verifyDisabledWorks: function() {
-    chrome.management.setEnabled(GOOD_CRX_ID, false,
-        this.runPendingRequests.bind(this, function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, false, function() {
       var node = getRequiredElement(GOOD_CRX_ID);
       assertTrue(node.classList.contains('inactive-extension'));
       this.nextStep();
-    }.bind(this)));
+    }.bind(this));
   },
 
   /** @protected */
   verifyEnabledWorks: function() {
-    chrome.management.setEnabled(GOOD_CRX_ID, true,
-        this.runPendingRequests.bind(this, function() {
+    chrome.management.setEnabled(GOOD_CRX_ID, true, function() {
       var node = getRequiredElement(GOOD_CRX_ID);
       assertFalse(node.classList.contains('inactive-extension'));
       this.nextStep();
-    }.bind(this)));
+    }.bind(this));
   },
 
   /** @protected */
   verifyUninstallWorks: function() {
+    var next = this.nextStep.bind(this);
     chrome.test.runWithUserGesture(function() {
-      chrome.management.uninstall(GOOD_CRX_ID,
-          this.runPendingRequests.bind(this, function() {
+      chrome.management.uninstall(GOOD_CRX_ID, function() {
         assertEquals(null, $(GOOD_CRX_ID));
-        this.nextStep();
-      }.bind(this)));
-    }.bind(this));
+        next();
+      });
+    });
   },
 };
 
 TEST_F('BasicExtensionSettingsWebUITest', 'testDisable', function() {
   this.steps = [this.waitForPageLoad,
                 this.verifyDisabledWorks,
                 testDone];
   this.nextStep();
 });
 
@@ skipping 182 matching lines @@
 
 ExtensionOptionsDialogWebUITest.prototype = {
   __proto__: InstalledExtensionSettingsWebUITest.prototype,
 
   /** @override */
   browsePreload: ExtensionSettingsWebUITest.prototype.browsePreload +
       '?options=' + GOOD_CRX_ID,
 };
 
 TEST_F('ExtensionOptionsDialogWebUITest', 'testAccessibility', runAudit);