Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(195)

Issue 1049453002: build/config: use "trim string" instead of "value" for clang revision (Closed)

Created:
5 years, 8 months ago by mdempsky
Modified:
5 years, 8 months ago
Reviewers:
Nico, scottmg
CC:
chromium-reviews, brettw, tfarina
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

build/config: use "trim string" instead of "value" for clang revision Clang revisions aren't always GN literals; e.g., right now it's "233105-1", but GN's "value" conversion parses as just "233105", silently ignoring the trailing "-1". See also discussion on gn-dev: https://groups.google.com/a/chromium.org/d/msg/gn-dev/hHRC1HuWBo8/drOd5dTvO5oJ Committed: https://crrev.com/985f4d610a682fb4059d0360fc4de9da45bf34d8 Cr-Commit-Position: refs/heads/master@{#322874}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/config/compiler/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 8 (2 generated)
mdempsky
5 years, 8 months ago (2015-03-30 20:20:21 UTC) #2
scottmg
I might have actually expected 233104. :) lgtm
5 years, 8 months ago (2015-03-30 20:22:11 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049453002/1
5 years, 8 months ago (2015-03-30 21:00:23 UTC) #5
Nico
lgtm Thanks much :-)
5 years, 8 months ago (2015-03-30 21:02:01 UTC) #6
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-30 21:37:34 UTC) #7
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 21:38:42 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/985f4d610a682fb4059d0360fc4de9da45bf34d8
Cr-Commit-Position: refs/heads/master@{#322874}

Powered by Google App Engine
This is Rietveld 408576698