Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 104943004: Have preloader handle crossorigin resources better. (Closed)

Created:
7 years ago by sof
Modified:
7 years ago
CC:
blink-reviews, dglazkov+blink, adamk+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Visibility:
Public.

Description

Have preloader handle crossorigin resources better. Make the preloading of resources understand CORS better: - correctly interpret a 'crossorigin' attribute without a value as "anonymous". - enable a CORS fetch if the attribute was present. For <script> and <img>, currently. R= BUG=324974 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=163210

Patch Set 1 #

Patch Set 2 : Initialize m_allowCredentials in the constructor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -15 lines) Patch
A LayoutTests/http/tests/security/script-crossorigin-loads-cross-origin-preload.html View 1 chunk +25 lines, -0 lines 0 comments Download
A LayoutTests/http/tests/security/script-crossorigin-loads-cross-origin-preload-expected.txt View 1 chunk +3 lines, -0 lines 0 comments Download
M Source/core/html/parser/HTMLPreloadScanner.cpp View 1 5 chunks +27 lines, -9 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.h View 3 chunks +10 lines, -3 lines 0 comments Download
M Source/core/html/parser/HTMLResourcePreloader.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
sof
At your leisure, please take a look.
7 years ago (2013-12-04 17:26:33 UTC) #1
abarth-chromium
lgtm Thanks for fixing this issue.
7 years ago (2013-12-04 17:34:23 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/104943004/1
7 years ago (2013-12-04 17:34:37 UTC) #3
sof
On 2013/12/04 17:34:23, abarth wrote: > lgtm > > Thanks for fixing this issue. Thanks, ...
7 years ago (2013-12-04 17:42:27 UTC) #4
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=19529
7 years ago (2013-12-04 19:37:28 UTC) #5
sof
Retries on win_blink_rel appears unrelated, so will try again. However, noticed that one field was ...
7 years ago (2013-12-04 19:56:17 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/104943004/20001
7 years ago (2013-12-04 19:56:41 UTC) #7
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) blink_platform_unittests, webkit_lint, webkit_python_tests, webkit_tests, webkit_unit_tests, wtf_unittests ...
7 years ago (2013-12-04 20:36:57 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/104943004/20001
7 years ago (2013-12-04 20:59:36 UTC) #9
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14543
7 years ago (2013-12-04 21:57:37 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/104943004/20001
7 years ago (2013-12-04 22:23:59 UTC) #11
commit-bot: I haz the power
Retried try job too often on linux_blink_rel for step(s) webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=linux_blink_rel&number=14555
7 years ago (2013-12-05 00:33:13 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/sigbjornf@opera.com/104943004/20001
7 years ago (2013-12-05 02:25:00 UTC) #13
commit-bot: I haz the power
7 years ago (2013-12-05 02:53:06 UTC) #14
Message was sent while issue was closed.
Change committed as 163210

Powered by Google App Engine
This is Rietveld 408576698