Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1049403002: Make 'See more' button in suggest apps dialog keyboard accessible (Closed)

Created:
5 years, 8 months ago by tbarzic
Modified:
5 years, 8 months ago
Reviewers:
yoshiki
CC:
chromium-reviews, rginda+watch_chromium.org, mtomasz+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make 'See more' button in suggest apps dialog keyboard accessible Also, fix the button icon positioning in rtl locale. BUG=None Committed: https://crrev.com/1922d15588699afc21dcace7e141721eb5844ff9 Cr-Commit-Position: refs/heads/master@{#323858}

Patch Set 1 #

Patch Set 2 : . #

Total comments: 2

Patch Set 3 : . #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -11 lines) Patch
M ui/file_manager/file_manager/foreground/css/file_manager.css View 1 2 1 chunk +17 lines, -6 lines 0 comments Download
M ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js View 1 2 3 chunks +32 lines, -5 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tbarzic
Please, take a look.
5 years, 8 months ago (2015-04-01 01:20:45 UTC) #2
yoshiki
lgtm with nit. https://codereview.chromium.org/1049403002/diff/20001/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js File ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js (right): https://codereview.chromium.org/1049403002/diff/20001/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js#newcode72 ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:72: webstoreButtonIcon.setAttribute('alt', ''); nit: Is this necessary? ...
5 years, 8 months ago (2015-04-02 07:51:19 UTC) #3
tbarzic
https://codereview.chromium.org/1049403002/diff/20001/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js File ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js (right): https://codereview.chromium.org/1049403002/diff/20001/ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js#newcode72 ui/file_manager/file_manager/foreground/js/ui/suggest_apps_dialog.js:72: webstoreButtonIcon.setAttribute('alt', ''); On 2015/04/02 07:51:19, yoshiki wrote: > nit: ...
5 years, 8 months ago (2015-04-03 20:38:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049403002/40001
5 years, 8 months ago (2015-04-03 21:07:09 UTC) #7
commit-bot: I haz the power
Committed patchset #3 (id:40001)
5 years, 8 months ago (2015-04-04 00:33:09 UTC) #8
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:34:00 UTC) #9
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/1922d15588699afc21dcace7e141721eb5844ff9
Cr-Commit-Position: refs/heads/master@{#323858}

Powered by Google App Engine
This is Rietveld 408576698