Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(60)

Issue 1049393002: Revert of media-internals: Simplify the code path for creating a media log entry (Closed)

Created:
5 years, 8 months ago by jianli
Modified:
5 years, 8 months ago
Reviewers:
DaleCurtis, wolenetz
CC:
chromium-reviews, mlamouri+watch-content_chromium.org, qsr+mojo_chromium.org, Aaron Boodman, posciak+watch_chromium.org, avayvod+watch_chromium.org, viettrungluu+watch_chromium.org, jam, mcasas+watch_chromium.org, ben+mojo_chromium.org, abarth-chromium, feature-media-reviews_chromium.org, darin-cc_chromium.org, yzshen+watch_chromium.org, mkwst+moarreviews-renderer_chromium.org, darin (slow to review), wjia+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@MEDIA_LOG_INFO_ERROR_DEBUG
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of media-internals: Simplify the code path for creating a media log entry (patchset #3 id:40001 of https://codereview.chromium.org/1047313002/) Reason for revert: http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/78706/steps/compile/logs/stdio Original issue's description: > media-internals: Simplify the code path for creating a media log entry > > Changes MediaLog::CreateLogEvent() to instead be a helper AddLogEvent() that > both creates and adds the event, and has signature and utility matching LogCB. > This means various media code pieces no longer must have their own LogCB > implementations that CreateLogEvent()+AddEvent(). > > BUG=471902, 260005 > TEST=no media_unittest, layout, or chrome://media-internals log regression observed > > Committed: https://crrev.com/aafe49fe9061c489906351db41c318473d1951af > Cr-Commit-Position: refs/heads/master@{#323149} TBR=dalecurtis@chromium.org,wolenetz@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=471902, 260005 Committed: https://crrev.com/16cd9613c88278d5429d6ba4394e48a516cc889a Cr-Commit-Position: refs/heads/master@{#323155}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -18 lines) Patch
M content/renderer/media/android/media_source_delegate.cc View 3 chunks +8 lines, -4 lines 0 comments Download
M media/base/media_log.h View 1 chunk +2 lines, -3 lines 0 comments Download
M media/base/media_log.cc View 1 chunk +7 lines, -4 lines 0 comments Download
M media/blink/webmediaplayer_impl.cc View 3 chunks +8 lines, -2 lines 0 comments Download
M media/mojo/services/mojo_renderer_service.cc View 2 chunks +10 lines, -4 lines 0 comments Download
M media/renderers/default_renderer_factory.cc View 2 chunks +10 lines, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
jianli
Created Revert of media-internals: Simplify the code path for creating a media log entry
5 years, 8 months ago (2015-04-01 00:34:38 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049393002/1
5 years, 8 months ago (2015-04-01 00:35:09 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-01 00:35:44 UTC) #3
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/16cd9613c88278d5429d6ba4394e48a516cc889a Cr-Commit-Position: refs/heads/master@{#323155}
5 years, 8 months ago (2015-04-01 00:36:38 UTC) #4
raymes
5 years, 8 months ago (2015-04-01 00:45:51 UTC) #5
Message was sent while issue was closed.
I've filed https://code.google.com/p/chromium/issues/detail?id=471952

Powered by Google App Engine
This is Rietveld 408576698