Chromium Code Reviews
DescriptionRevert of media-internals: Simplify the code path for creating a media log entry (patchset #3 id:40001 of https://codereview.chromium.org/1047313002/)
Reason for revert:
http://build.chromium.org/p/chromium.webkit/builders/Mac%20Builder%20%28dbg%29/builds/78706/steps/compile/logs/stdio
Original issue's description:
> media-internals: Simplify the code path for creating a media log entry
>
> Changes MediaLog::CreateLogEvent() to instead be a helper AddLogEvent() that
> both creates and adds the event, and has signature and utility matching LogCB.
> This means various media code pieces no longer must have their own LogCB
> implementations that CreateLogEvent()+AddEvent().
>
> BUG=471902, 260005
> TEST=no media_unittest, layout, or chrome://media-internals log regression observed
>
> Committed: https://crrev.com/aafe49fe9061c489906351db41c318473d1951af
> Cr-Commit-Position: refs/heads/master@{#323149}
TBR=dalecurtis@chromium.org,wolenetz@chromium.org
NOPRESUBMIT=true
NOTREECHECKS=true
NOTRY=true
BUG=471902, 260005
Committed: https://crrev.com/16cd9613c88278d5429d6ba4394e48a516cc889a
Cr-Commit-Position: refs/heads/master@{#323155}
Patch Set 1 #
Created: 5 years, 8 months ago
(Patch set is too large to download)
Messages
Total messages: 5 (0 generated)
|
||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||