Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(52)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1049343002: Make the test server's SlowServerHandler match the documentation. (Closed)

Created:
5 years, 8 months ago by davidben
Modified:
5 years, 8 months ago
Reviewers:
eroman
CC:
chromium-reviews, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Make the test server's SlowServerHandler match the documentation. Fractional timeouts currently silently turn into 1.0 seconds. BUG=none Committed: https://crrev.com/41a453a212a142beab3e0391461d0b90f2449a4c Cr-Commit-Position: refs/heads/master@{#323104}

Patch Set 1 #

Patch Set 2 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -2 lines) Patch
M net/tools/testserver/testserver.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
davidben
Noticed this while reviewing your CL. Code potentially affected: https://code.google.com/p/chromium/codesearch#search/&q=slow%5B%5E%20%5D*%5C?%5B0-9.%5D&sq=package:chromium&type=cs
5 years, 8 months ago (2015-03-31 20:23:09 UTC) #2
eroman
hah! LGTM
5 years, 8 months ago (2015-03-31 20:34:59 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049343002/20001
5 years, 8 months ago (2015-03-31 20:39:12 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 20:48:16 UTC) #6
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 20:49:03 UTC) #7
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/41a453a212a142beab3e0391461d0b90f2449a4c
Cr-Commit-Position: refs/heads/master@{#323104}

Powered by Google App Engine
This is Rietveld 408576698