ES6: Error functions should extend Error

ES6: Error functions should extend Error

The /NativeError/ functions should have Error as their [[Prototype]].

http://people.mozilla.org/~jorendorff/es6-draft.html#sec-properties-of-the-nativeerror-constructors

BUG=v8:3998
LOG=N
R=adamk, dslomov@chromium.org
CQ_INCLUDE_TRYBOTS=tryserver.chromium.linux:linux_chromium_rel_ng;tryserver.blink:linux_blink_rel

Committed: https://crrev.com/18cb17c924e699d3560fbd854562c7f00357e0f1
Cr-Commit-Position: refs/heads/master@{#27572}

[arv (Not doing code reviews), 2015-03-31 22:37:46]

PTAL

[adamk, 2015-03-31 22:45:12]

https://codereview.chromium.org/1049323003/diff/20001/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/1049323003/diff/20001/src/messages.js#newcode...
src/messages.js:1167: %SetPrototype(f, $Error);
Any reason not to use %InternalSetPrototype here?

[arv (Not doing code reviews), 2015-03-31 22:48:14]

Use InternalSetPrototype instead

[arv (Not doing code reviews), 2015-03-31 22:48:27]

PTAL

https://codereview.chromium.org/1049323003/diff/20001/src/messages.js
File src/messages.js (right):

https://codereview.chromium.org/1049323003/diff/20001/src/messages.js#newcode...
src/messages.js:1167: %SetPrototype(f, $Error);
On 2015/03/31 22:45:12, adamk wrote:
> Any reason not to use %InternalSetPrototype here?

Yes, the reason is that I'm stupid. Fixing.

[adamk, 2015-03-31 22:49:57]

lgtm

No, you're not stupid :)

[arv (Not doing code reviews), 2015-03-31 23:17:16]

The CQ bit was checked by arv@chromium.org

[commit-bot: I haz the power, 2015-03-31 23:17:34]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049323003/40001

[commit-bot: I haz the power, 2015-04-01 00:23:48]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-04-01 00:23:49]

Failed to apply patch for test/test262-es6/test262-es6.status:
While running git apply --index -3 -p1;
  error: patch failed: test/test262-es6/test262-es6.status:275
  Falling back to three-way merge...
  Applied patch to 'test/test262-es6/test262-es6.status' with conflicts.
  U test/test262-es6/test262-es6.status

Patch:       test/test262-es6/test262-es6.status
Index: test/test262-es6/test262-es6.status
diff --git a/test/test262-es6/test262-es6.status
b/test/test262-es6/test262-es6.status
index
794805eeb965644f5792e70b2d04c5ae4b687791..e35b7b1591ba3dba9fd493011305d34571f0f9ae
100644
--- a/test/test262-es6/test262-es6.status
+++ b/test/test262-es6/test262-es6.status
@@ -275,12 +275,6 @@
   'built-ins/Object/getPrototypeOf/15.2.3.2-1': [FAIL],
   'built-ins/Object/getPrototypeOf/15.2.3.2-1-3': [FAIL],
   'built-ins/Object/getPrototypeOf/15.2.3.2-1-4': [FAIL],
-  'built-ins/Object/getPrototypeOf/15.2.3.2-2-12': [FAIL],
-  'built-ins/Object/getPrototypeOf/15.2.3.2-2-13': [FAIL],
-  'built-ins/Object/getPrototypeOf/15.2.3.2-2-14': [FAIL],
-  'built-ins/Object/getPrototypeOf/15.2.3.2-2-15': [FAIL],
-  'built-ins/Object/getPrototypeOf/15.2.3.2-2-16': [FAIL],
-  'built-ins/Object/getPrototypeOf/15.2.3.2-2-17': [FAIL],
   'built-ins/Object/isExtensible/15.2.3.13-1': [FAIL],
   'built-ins/Object/isExtensible/15.2.3.13-1-1': [FAIL],
   'built-ins/Object/isExtensible/15.2.3.13-1-2': [FAIL],

[commit-bot: I haz the power, 2015-04-01 00:23:52]

The CQ bit was unchecked by commit-bot@chromium.org

[arv (Not doing code reviews), 2015-04-01 16:19:09]

Fix and cleanup test

[arv (Not doing code reviews), 2015-04-01 16:20:28]

The CQ bit was checked by arv@chromium.org

[arv (Not doing code reviews), 2015-04-01 16:20:29]

The patchset sent to the CQ was uploaded after l-g-t-m from adamk@chromium.org
Link to the patchset: https://codereview.chromium.org/1049323003/#ps60001
(title: "Fix and cleanup test")

[commit-bot: I haz the power, 2015-04-01 16:20:40]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1049323003/60001

[commit-bot: I haz the power, 2015-04-01 17:29:53]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-04-01 17:30:13]

Patchset 4 (id:??) landed as
https://crrev.com/18cb17c924e699d3560fbd854562c7f00357e0f1
Cr-Commit-Position: refs/heads/master@{#27572}