Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(262)

Issue 1049253004: PPC: [turbofan] Add backend support for float32 operations. (Closed)

Created:
5 years, 8 months ago by michael_dawson
Modified:
5 years, 8 months ago
Reviewers:
MTBrandyberry
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

PPC: [turbofan] Add backend support for float32 operations. Port 8dad78cdbd21c2cd02d6e0645313bd4b9983c78e Original commit message: This adds the basics necessary to support float32 operations in TurboFan. The actual functionality required to detect safe float32 operations will be added based on this later. Therefore this does not affect production code except for some cleanup/refactoring. In detail, this patchset contains the following features: - Add support for float32 operations to arm, arm64, ia32 and x64 backends. - Add float32 machine operators. - Add support for float32 constants to simplified lowering. - Handle float32 representation for phis in simplified lowering. In addition, contains the following (related) cleanups: - Fix/unify naming of backend instructions. - Use AVX comparisons when available. - Extend ArchOpcodeField to 9 bits (required for arm64). - Refactor some code duplication in instruction selectors. BUG=v8:3589 LOG=N R=mbrandy@us.ibm.com Committed: https://crrev.com/2dd659f8e71bc02ea8afd1ddcf05fe7cc27a61ba Cr-Commit-Position: refs/heads/master@{#27547}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+326 lines, -246 lines) Patch
M src/compiler/ppc/code-generator-ppc.cc View 20 chunks +112 lines, -77 lines 0 comments Download
M src/compiler/ppc/instruction-codes-ppc.h View 4 chunks +36 lines, -45 lines 0 comments Download
M src/compiler/ppc/instruction-selector-ppc.cc View 36 chunks +178 lines, -124 lines 0 comments Download

Messages

Total messages: 10 (3 generated)
michael_dawson
Next PPC port
5 years, 8 months ago (2015-03-31 14:08:26 UTC) #1
MTBrandyberry
On 2015/03/31 14:08:26, michael_dawson wrote: > Next PPC port lgtm
5 years, 8 months ago (2015-03-31 14:14:28 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049253004/1
5 years, 8 months ago (2015-03-31 14:28:20 UTC) #4
commit-bot: I haz the power
Try jobs failed on following builders: v8_presubmit on tryserver.v8 (JOB_FAILED, http://build.chromium.org/p/tryserver.v8/builders/v8_presubmit/builds/1653)
5 years, 8 months ago (2015-03-31 14:32:28 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049253004/1
5 years, 8 months ago (2015-03-31 14:52:18 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-03-31 14:54:36 UTC) #9
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 14:54:49 UTC) #10
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/2dd659f8e71bc02ea8afd1ddcf05fe7cc27a61ba
Cr-Commit-Position: refs/heads/master@{#27547}

Powered by Google App Engine
This is Rietveld 408576698