LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html - Issue 1049233003: Keep the selection of the text field when changed by JS.

Side by Side Diff: LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events.html

Issue 1049233003: Keep the selection of the text field when changed by JS. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range.html ('K') | « LayoutTests/fast/events/touch/gesture/gesture-tap-reset-selection-range-expected.txt ('k') | LayoutTests/fast/events/touch/gesture/gesture-tap-setrangetext-with-events-expected.txt » ('j') | Source/core/editing/SelectionController.cpp » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
(Empty)
	1 <!DOCTYPE html>

	2 <script src="../../../../resources/js-test.js"></script>
	yosin_UTC9 2015/07/06 01:57:30 This is optional. Do you want to try new framewor This is optional. Do you want to try new framework, W3C test harness? Good thing is we don't need to have expected text. Example: https://chromium.googlesource.com/chromium/blink/+/master/LayoutTests/editing... Just call \|test(closure, testName)\|, \|testName\| will be print when failed. Functions: assert_equals(), assert_false(), assert_true(). Miyoung Shin(g) 2015/07/13 03:32:57 I've changed all test cases of this patch to W3C t Show quoted text On 2015/07/06 01:57:30, Yosi_UTC9 wrote: > This is optional. > > Do you want to try new framework, W3C test harness? Good thing is we don't need > to have expected text. > > Example: > https://chromium.googlesource.com/chromium/blink/+/master/LayoutTests/editing... > > Just call \|test(closure, testName)\|, \|testName\| will be print when failed. > > Functions: assert_equals(), assert_false(), assert_true(). > I've changed all test cases of this patch to W3C test harness. Thanks for the good information.
	3 <script>

	4 description("This tests the selection of the text field after setSelectionRa nge is called during a tap");

	5 window.onload = function() {

	6 if (window.eventSender) {

	7 doSetSelectionRange('focus');

	8 doSetSelectionRange('mousedown');

	9 doSetSelectionRange('mouseup');

	10 doSetSelectionRange('click');

	11 }

	12 }

	13

	14 function doSetSelectionRange(event) {
	yosin_UTC9 2015/07/06 01:57:29 nit: It is better to use \|eventType\| or \|eventName nit: It is better to use \|eventType\| or \|eventName\| rather than \|event\|. It is confusing \|event\| containing \|Event\| object. Miyoung Shin(g) 2015/07/13 03:32:57 Done. Show quoted text On 2015/07/06 01:57:29, Yosi_UTC9 wrote: > nit: It is better to use \|eventType\| or \|eventName\| rather than \|event\|. > It is confusing \|event\| containing \|Event\| object. Done.
	15 debug(event + ' test :');

	16 var textfield = document.getElementById('textfield');

	17 textfield.setSelectionRange(0, 0);

	18 var tx = textfield.offsetLeft + 4;

	19 var ty = textfield.offsetTop + 4;

	20

	21 textfield.addEventListener(event, setSelectionRange);

	22 eventSender.gestureTapDown(tx, ty);

	23 eventSender.gestureShowPress(tx, ty);

	24 eventSender.gestureTap(tx, ty);

	25 if (event == 'mousedown') {
	yosin_UTC9 2015/07/06 01:57:29 nit: s/==/===/ nit: s/==/===/ Miyoung Shin(g) 2015/07/13 03:32:57 Done. I've changed it to === operator. Show quoted text On 2015/07/06 01:57:29, Yosi_UTC9 wrote: > nit: s/==/===/ Done. I've changed it to === operator.
	26 shouldBe('textfield.selectionStart', '0');
	yosin_UTC9 2015/07/06 01:57:29 \|shouldBeZero()\| \|shouldBeZero()\|
	27 shouldBe('textfield.selectionEnd', '0');
	yosin_UTC9 2015/07/06 01:57:29 \|shouldBeZero()\| \|shouldBeZero()\|
	28 } else {

	29 shouldBe('textfield.selectionStart', '0');
	yosin_UTC9 2015/07/06 01:57:29 \|shouldBeZero()\| \|shouldBeZero()\|
	30 shouldBe('textfield.selectionEnd', '5');

	31 }

	32 textfield.setSelectionRange(0, 0);

	33 textfield.removeEventListener(event, setSelectionRange);

	34 }

	35

	36 function setSelectionRange(e) {

	37 var textfield = document.getElementById('textfield');

	38 textfield.setSelectionRange(0, textfield.value.length);

	39 }

	40 </script>

	41 <input type="text" value="value" id="textfield"></input>

OLD	NEW