Issue 104923014: Write the make_global_settings to the error message.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 104923014: Write the make_global_settings to the error message. (Closed)

Created:
7 years ago by brettw

Modified:
6 years, 12 months ago

Reviewers:
M-A Ruel

CC:
gyp-developer_googlegroups.com

Base URL:
http://gyp.googlecode.com/svn/trunk/

Visibility:
Public.

More Reviews

Description

Write the make_global_settings to the error message. I'm trying to land some GN changes and get this error on various platforms with various configurations. Having the actual values that GYP and GN end up with for the make_global_settings will make troubleshooting much faster. R=maruel@chromium.org Committed: https://code.google.com/p/gyp/source/detail?r=1827

Patch Set 1 #

Total comments: 2

Patch Set 2 : #

Created: 6 years, 12 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -2 lines)			Patch
	M	pylib/gyp/generator/make.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download
	M	pylib/gyp/generator/ninja.py	View	1	1 chunk	+2 lines, -1 line	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

M-A Ruel

I'm not technically a gyp reviewer but since it's just changing two assert description text, ...

6 years, 12 months ago (2013-12-24 13:53:03 UTC) #2

Message was sent while issue was closed.

Committed patchset #2 manually as r1827.

Expand Messages | Collapse Messages