Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(315)

Issue 104923010: Remove flag track-allocation-sites. (Closed)

Created:
7 years ago by mvstanton
Modified:
6 years, 11 months ago
CC:
v8-dev
Visibility:
Public.

Description

Remove flag track-allocation-sites. The flag has been on in the build for ~9 months, and we aren't likely to turn it off. The only customer of the flag is a set of tests that want to verify transitioning behavior in isolation. This CL removes the flag and updates those tests to get what they want without the flag. R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18385 Committed: https://code.google.com/p/v8/source/detail?r=18474

Patch Set 1 #

Patch Set 2 : Got tests working #

Patch Set 3 : Addressed feedback #

Patch Set 4 : REBASE #

Patch Set 5 : Included ports this time! #

Unified diffs Side-by-side diffs Delta from patch set Stats (+161 lines, -138 lines) Patch
M src/arm/code-stubs-arm.cc View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M src/arm/full-codegen-arm.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/code-stubs.h View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/flag-definitions.h View 1 2 3 4 1 chunk +0 lines, -2 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M src/mips/full-codegen-mips.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M src/objects.cc View 1 2 3 4 2 chunks +19 lines, -21 lines 0 comments Download
M src/objects-inl.h View 1 2 3 4 2 chunks +2 lines, -4 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 1 2 3 4 1 chunk +1 line, -6 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 1 2 3 4 1 chunk +1 line, -2 lines 0 comments Download
M test/mjsunit/allocation-site-info.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-constructor-feedback.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-feedback.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-literal-feedback.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/array-natives-elements.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/elements-kind.js View 1 2 2 chunks +59 lines, -45 lines 0 comments Download
M test/mjsunit/elements-transition.js View 1 2 3 chunks +29 lines, -11 lines 0 comments Download
M test/mjsunit/elements-transition-and-store.js View 1 1 chunk +0 lines, -2 lines 0 comments Download
M test/mjsunit/elements-transition-hoisting.js View 1 2 3 chunks +10 lines, -5 lines 0 comments Download
M test/mjsunit/opt-elements-kind.js View 1 2 chunks +13 lines, -2 lines 0 comments Download
M test/mjsunit/osr-elements-kind.js View 1 2 chunks +12 lines, -2 lines 0 comments Download
M test/mjsunit/regress/regress-320532.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-convert-hole2.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-244461.js View 1 1 chunk +0 lines, -1 line 0 comments Download
M test/mjsunit/regress/regress-crbug-245480.js View 1 1 chunk +1 line, -1 line 0 comments Download
M test/mjsunit/transition-elements-kind.js View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
mvstanton
Hi Benedikt, per our discussion, this is a cleanup CL that removes an unnecessary flag. ...
7 years ago (2013-12-09 14:20:19 UTC) #1
mvstanton
Hi Benedikt, I removed the unfortunate ClearTypeFeedback hack. PTAL, thx! --Michael
7 years ago (2013-12-13 14:17:56 UTC) #2
mvstanton
Hi Toon, since Benedikt is out for a while can you have a look? We ...
7 years ago (2013-12-17 13:56:24 UTC) #3
Toon Verwaest
lgtm
7 years ago (2013-12-18 14:06:35 UTC) #4
mvstanton
Committed patchset #4 manually as r18385 (presubmit successful).
7 years ago (2013-12-20 11:46:48 UTC) #5
mvstanton
6 years, 11 months ago (2014-01-07 15:58:45 UTC) #6
Message was sent while issue was closed.
Committed patchset #5 manually as r18474 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698