Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(90)

Issue 1049223003: Sketch SkFunction (Closed)

Created:
5 years, 8 months ago by mtklein_C
Modified:
5 years, 8 months ago
Reviewers:
bungeman-skia, mtklein
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Sketch SkFunction Let's start with baby steps in case some bot can't handle this. I have left many TODOs, most of which I know how to do if this looks feasible and useful. BUG=skia: Committed: https://skia.googlesource.com/skia/+/4a9426f0fa812c0f1bffa84f0dae0926607a9543

Patch Set 1 #

Patch Set 2 : VTable impl #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -0 lines) Patch
M gyp/tests.gypi View 1 chunk +1 line, -0 lines 0 comments Download
A src/core/SkFunction.h View 1 1 chunk +70 lines, -0 lines 0 comments Download
A tests/FunctionTest.cpp View 1 chunk +27 lines, -0 lines 0 comments Download

Messages

Total messages: 18 (8 generated)
mtklein_C
5 years, 8 months ago (2015-03-31 19:15:33 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049223003/1
5 years, 8 months ago (2015-03-31 19:19:37 UTC) #4
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-03-31 19:19:38 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049223003/1
5 years, 8 months ago (2015-03-31 19:30:47 UTC) #8
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-03-31 19:38:38 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049223003/20001
5 years, 8 months ago (2015-03-31 20:36:06 UTC) #12
commit-bot: I haz the power
This issue passed the CQ dry run.
5 years, 8 months ago (2015-03-31 20:56:49 UTC) #14
bungeman-skia
lgtm
5 years, 8 months ago (2015-03-31 21:18:49 UTC) #15
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049223003/20001
5 years, 8 months ago (2015-03-31 21:24:14 UTC) #17
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 21:24:32 UTC) #18
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://skia.googlesource.com/skia/+/4a9426f0fa812c0f1bffa84f0dae0926607a9543

Powered by Google App Engine
This is Rietveld 408576698