Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(169)

Issue 1049203002: [turbofan] Make throwing expressions kill the environment. (Closed)

Created:
5 years, 8 months ago by Michael Starzinger
Modified:
5 years, 8 months ago
Reviewers:
Sven Panne
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

[turbofan] Make throwing expressions kill the environment. This ensures that all expressions that throw actually mark the current environment as dead in the AstGraphBuilder. This prevents live ranges from being unnecessarily increased by paths that don't fall-through. Note that we can do that because Runtime::kThrowFoo never returns. R=svenpanne@chromium.org Committed: https://crrev.com/e5ac65094cbda4f6345a0633d592c4cbe2c58446 Cr-Commit-Position: refs/heads/master@{#27546}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+23 lines, -10 lines) Patch
M src/compiler/ast-graph-builder.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/compiler/ast-graph-builder.cc View 1 4 chunks +22 lines, -10 lines 0 comments Download

Messages

Total messages: 6 (1 generated)
Michael Starzinger
5 years, 8 months ago (2015-03-31 11:07:02 UTC) #1
Sven Panne
lgtm
5 years, 8 months ago (2015-03-31 13:57:31 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1049203002/20001
5 years, 8 months ago (2015-03-31 14:24:24 UTC) #4
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 8 months ago (2015-03-31 14:26:01 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-03-31 14:26:09 UTC) #6
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/e5ac65094cbda4f6345a0633d592c4cbe2c58446
Cr-Commit-Position: refs/heads/master@{#27546}

Powered by Google App Engine
This is Rietveld 408576698