UI fix for fullscreen permission on single website preference.

UI fix for fullscreen permission on single website preference.

Currently for fullscreen permission, user can only change it by reset all the preferences.
This change adds a delete button next to the fullscreen permission on single website preference page. 
When user clicks that button, a confirmation dialog shows up to confirm that user will reset the fullscreen permission.
It also fixes the missing fullscreen permission on the single site preference UI.

BUG=378412

[qinmin, 2015-03-30 23:33:42]

Patchset #1 (id:1) has been deleted

[qinmin, 2015-03-30 23:34:34]

qinmin@chromium.org changed reviewers:
+ finnur@chromium.org

[qinmin, 2015-03-30 23:34:35]

PTAL

[Finnur, 2015-03-31 12:11:33]

finnur@chromium.org changed reviewers:
+ rolfe@chromium.org

[Finnur, 2015-03-31 12:11:34]

General comments on the CL description:

> This change adds a delete button besides the fullscreen permission.

Hmmm... Not sure that's accurate. It looks to me like this removes the Full
screen permission widget on the Site details page and replaces it with a Delete
button. No?

> It also fixes the display issue of the fullscreen permission

Which display issue?


But, lets take a step back... I don't think this is the right approach. 

I am also getting a bit worried that some of my review requests have been
ignored. For example, did you discuss this approach with Rebecca Rolfe, like I
requested? I don't recognize her fingerprints on this design and I'm worried
that pursuing this is going to look bad aesthetically and create user confusion.

There was a proposal at one point to add a Reset button after each permission,
which would allow the user to selectively reset permissions. I think that would
be a much better way to go. Something like:

[icon] Full Screen    [X]
       Allow

Another (easier) option is to make the options in the combo box be [ Allow |
Revoke ] and when you select Revoke the permission gets deleted. But the
previous proposal is probably clearer and better UX (but harder to implement).

While we wait for a solution, I would probably make this widget disabled, so
people can *see* that FullScreen has been granted but cannot change it to Block.
They can still reset the whole site to get rid of that permission, so they
wouldn't be stuck with it. Actually, they are stuck with it today, so they are
no worse off...

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/xml/single_website_preferences.xml (right):

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/res...
chrome/android/java/res/xml/single_website_preferences.xml:45:
android:positiveButtonText="@string/ok"
OK buttons are not cool. Use a verb that describes the action (Reset/Delete or
something).

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:459:
mSite.setFullscreenPermission(ContentSetting.ASK);
This is not correct. You should pass in null here to get it to delete the
permission. We shouldn't be setting it explicitly to ASK.

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:460:
PreferenceScreen preferenceScreen = getPreferenceScreen();
nit: Use this variable on lines 461 and 462?

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:616: Fullscreen
permission will be revoked for this site
nit: Missing period at end.

[qinmin, 2015-03-31 16:57:49]

Hi, Finnur. Sorry, I am not very familiar with the UI design  workflow so I may
miss a couple things here and there.
I've attached the screenshots on crbug.com/378412 and asked rolfe@ for
suggestions.

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/res...
File chrome/android/java/res/xml/single_website_preferences.xml (right):

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/res...
chrome/android/java/res/xml/single_website_preferences.xml:45:
android:positiveButtonText="@string/ok"
On 2015/03/31 12:11:34, Finnur wrote:
> OK buttons are not cool. Use a verb that describes the action (Reset/Delete or
> something).

Done.

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/src...
File
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java
(right):

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:459:
mSite.setFullscreenPermission(ContentSetting.ASK);
On 2015/03/31 12:11:34, Finnur wrote:
> This is not correct. You should pass in null here to get it to delete the
> permission. We shouldn't be setting it explicitly to ASK.

Done.

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/src...
chrome/android/java/src/org/chromium/chrome/browser/preferences/website/SingleWebsitePreferences.java:460:
PreferenceScreen preferenceScreen = getPreferenceScreen();
On 2015/03/31 12:11:34, Finnur wrote:
> nit: Use this variable on lines 461 and 462?

Done.

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/str...
File chrome/android/java/strings/android_chrome_strings.grd (right):

https://codereview.chromium.org/1049083002/diff/20001/chrome/android/java/str...
chrome/android/java/strings/android_chrome_strings.grd:616: Fullscreen
permission will be revoked for this site
On 2015/03/31 12:11:34, Finnur wrote:
> nit: Missing period at end.

Done.

[qinmin, 2015-04-01 00:19:30]

Patchset #2 (id:40001) has been deleted