Generalize AllocationMemento::FindForHeapObject and remove corresponding new space check.

Generalize AllocationMemento::FindForHeapObject and remove corresponding new space check.

BUG=
R=mvstanton@chromium.org

Committed: https://code.google.com/p/v8/source/detail?r=18366

[mvstanton, 2013-12-04 16:16:49]

Provided the comment below is addressed, then LGTM.

https://codereview.chromium.org/104903002/diff/10001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/104903002/diff/10001/src/objects.cc#newcode9181
src/objects.cc:9181: if (FLAG_track_allocation_sites) {
I think you want to add the check in method JSObject::UpdateAllocationSite(),
which is the client for the transitioning case. I'm pretty sure we could get
into there with some old space object.

[Hannes Payer (out of office), 2013-12-04 16:28:30]

https://codereview.chromium.org/104903002/diff/10001/src/objects.cc
File src/objects.cc (right):

https://codereview.chromium.org/104903002/diff/10001/src/objects.cc#newcode9181
src/objects.cc:9181: if (FLAG_track_allocation_sites) {
On 2013/12/04 16:16:50, mvstanton wrote:
> I think you want to add the check in method JSObject::UpdateAllocationSite(),
> which is the client for the transitioning case. I'm pretty sure we could get
> into there with some old space object.

Done.

[mvstanton, 2013-12-13 10:32:36]

lgtm

[Hannes Payer (out of office), 2013-12-18 20:09:02]

Committed patchset #4 manually as r18366 (presubmit successful).