mojo/services/html_viewer/ax_provider_impl.cc - Issue 1049013004: Add some simple HTMLViewer apptests.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/services/html_viewer/ax_provider_impl.cc

Issue 1049013004: Add some simple HTMLViewer apptests. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Use net::SpawnedTestServer instead of mojo:http_server. Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/services/html_viewer/ax_provider_impl.cc

diff --git a/mojo/services/html_viewer/ax_provider_impl.cc b/mojo/services/html_viewer/ax_provider_impl.cc

index 11a1356b45f80a3edbb7e605812edf1df46ab373..609e01491547be35c314c3141d16757becf4b853 100644

--- a/mojo/services/html_viewer/ax_provider_impl.cc

+++ b/mojo/services/html_viewer/ax_provider_impl.cc

@@ -28,9 +28,14 @@ void AxProviderImpl::GetTree(

web_view_->settings()->setAccessibilityEnabled(true);

web_view_->settings()->setInlineTextBoxAccessibilityEnabled(true);

- Array<AxNodePtr> result;

- Populate(web_view_->accessibilityObject(), 0, 0, &result);

- callback.Run(result.Pass());

+ // TODO(msw): Is this a deep copy?

+ WebAXObject web_ax_object = web_view_->accessibilityObject();

+ DCHECK(!web_ax_object.isDetached());

+ if (web_ax_object.updateLayoutAndCheckValidity()) {

+ Array<AxNodePtr> result;

+ Populate(web_ax_object, 0, 0, &result);

+ callback.Run(result.Pass());

+ }

}

int AxProviderImpl::Populate(const WebAXObject& ax_object,