components/password_manager/core/browser/password_form_manager_unittest.cc - Issue 1049003002: [Password Manager] Add UMA stats for submitted form type

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/password_manager/core/browser/password_form_manager_unittest.cc

Issue 1049003002: [Password Manager] Add UMA stats for submitted form type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Cleanup Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« components/password_manager/core/browser/password_form_manager.cc ('K') | « components/password_manager/core/browser/password_form_manager.cc ('k') | components/password_manager/core/browser/password_manager.cc » ('j') | tools/metrics/histograms/histograms.xml » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/password_manager/core/browser/password_form_manager_unittest.cc

diff --git a/components/password_manager/core/browser/password_form_manager_unittest.cc b/components/password_manager/core/browser/password_form_manager_unittest.cc

index 286582d23d4c0f2b06140312f4a1813c51850f66..72ac326a7d0f0a5ed80bcfa0ffa515cc2fca318e 100644

--- a/components/password_manager/core/browser/password_form_manager_unittest.cc

+++ b/components/password_manager/core/browser/password_form_manager_unittest.cc

@@ -1402,7 +1402,8 @@ TEST_F(PasswordFormManagerTest,

credentials.password_value = saved_match()->password_value;

credentials.new_password_value = ASCIIToUTF16("NewPassword");

- EXPECT_FALSE(manager.IsIgnorableChangePasswordForm(credentials));

+ manager.SetSubmittedForm(credentials);

+ EXPECT_FALSE(manager.IsIgnorableChangePasswordForm());

}

TEST_F(PasswordFormManagerTest,

@@ -1422,7 +1423,8 @@ TEST_F(PasswordFormManagerTest,

saved_match()->new_password_element =

base::ASCIIToUTF16("new_password_field");

saved_match()->new_password_value = base::ASCIIToUTF16("new_pwd");

- EXPECT_TRUE(manager.IsIgnorableChangePasswordForm(*saved_match()));

+ manager.SetSubmittedForm(*saved_match());

+ EXPECT_TRUE(manager.IsIgnorableChangePasswordForm());

}