Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(140)

Unified Diff: tools/metrics/histograms/histograms.xml

Side-by-side diff isn't available for this file because of its large size.
Issue 1049003002: [Password Manager] Add UMA stats for submitted form type (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Cleanup Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
Download patch
Index: tools/metrics/histograms/histograms.xml
diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml
index 500c47d0ae272e6042d4d995f4d05deca146b85c..fed58b63ca318674932c9d5987858d85a132a812 100644
--- a/tools/metrics/histograms/histograms.xml
+++ b/tools/metrics/histograms/histograms.xml
@@ -24821,6 +24821,15 @@ Therefore, the affected-histogram name has to have at least one dot in it.
</summary>
</histogram>
+<histogram name="PasswordManager.SubmittedFormType" enum="PasswordFormType">
+ <owner>gcasto@chromium.org</owner>
+ <owner>vabr@chromium.org</owner>
+ <summary>
+ The type (e.g. signup, login, change password) of all submitted password
vabr (Chromium) 2015/03/31 10:08:18 nit: two spaces after "type" -- intentional?
Garrett Casto 2015/04/01 22:34:48 Nope, fixed.
+ forms.
+ </summary>
+</histogram>
+
<histogram name="PasswordManager.SyncCredentialFiltered" enum="Boolean">
<owner>gcasto@chromium.org</owner>
<owner>vabr@chromium.org</owner>
@@ -56244,6 +56253,19 @@ To add a new entry, add it with any value and run test to compute valid value.
<int value="6" label="Opened automatically / Auto-signin toast"/>
</enum>
+<enum name="PasswordFormType" type="int">
+ <int value="0" label="Login form"/>
+ <int value="1" label="Login form without username"/>
+ <int value="2"
+ label="Enabled change password form (saved credentials match username)"/>
+ <int value="3"
+ label="Disabled change password form (no matching credentials)"/>
+ <int value="4" label="Disabled change password form without username"/>
+ <int value="5" label="Signup form"/>
+ <int value="6" label="Signup form without username"/>
+ <int value="7" label="Combined login and signup form"/>
+</enum>
+
<enum name="PasswordGenerationEvent" type="int">
<int value="0" label="No sign up form"/>
<int value="1" label="Local heuristics found sign up form"/>

Powered by Google App Engine
This is Rietveld 408576698