Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1728)

Unified Diff: content/renderer/render_frame_impl.cc

Issue 1048963002: Fix incorrect creation of duplicate navigation entries for repeated page load failures. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@committype3
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/renderer/render_frame_impl.cc
diff --git a/content/renderer/render_frame_impl.cc b/content/renderer/render_frame_impl.cc
index 259b4146192822f41624006f67824fd4cecfd186..9f001c925f220671c91bce15c2a6a0fc79c35ce5 100644
--- a/content/renderer/render_frame_impl.cc
+++ b/content/renderer/render_frame_impl.cc
@@ -2551,16 +2551,8 @@ void RenderFrameImpl::didFailProvisionalLoad(
// 'replace' load. This is necessary to avoid messing up session history.
// Otherwise, we do a normal load, which simulates a 'go' navigation as far
// as session history is concerned.
- //
- // AUTO_SUBFRAME loads should always be treated as loads that do not advance
- // the page id.
- //
- // TODO(davidben): This should also take the failed navigation's replacement
- // state into account, if a location.replace() failed.
- bool replace =
- navigation_state->request_params().page_id != -1 ||
- ui::PageTransitionCoreTypeIs(navigation_state->GetTransitionType(),
- ui::PAGE_TRANSITION_AUTO_SUBFRAME);
+ bool replace = commit_type != blink::WebStandardCommit ||
+ navigation_state->start_params().should_replace_current_entry;
// If we failed on a browser initiated request, then make sure that our error
// page load is regarded as the same browser initiated request.

Powered by Google App Engine
This is Rietveld 408576698