Eliminate use of and remove PathCoordinateMode

Eliminate use of and remove PathCoordinateMode

No longer used by SVGPathConsumer. Used by SVGPathBlender to decide
what the blending result will be.
Replace with bools in SVGPathBlender.

BUG=467592
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=193009

[fs, 2015-03-31 18:41:38]

fs@opera.com changed reviewers:
+ fmalita@chromium.org, pdr@chromium.org, schenney@chromium.org

[pdr., 2015-04-01 00:03:49]

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
File Source/core/svg/SVGPathBlender.cpp (right):

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
Source/core/svg/SVGPathBlender.cpp:324: m_fromIsAbsolute =
isAbsolutePathSegType(fromSeg.command);
If m_typesAreEqual is false, won't we neglect to update this value?

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
File Source/core/svg/SVGPathBlender.h (right):

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
Source/core/svg/SVGPathBlender.h:74: bool m_typesAreEqual;
WDYT about a comment here saying that these 3 bools are for the current from and
to segments?

[fs, 2015-04-01 09:15:55]

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
File Source/core/svg/SVGPathBlender.cpp (right):

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
Source/core/svg/SVGPathBlender.cpp:324: m_fromIsAbsolute =
isAbsolutePathSegType(fromSeg.command);
On 2015/04/01 00:03:49, pdr wrote:
> If m_typesAreEqual is false, won't we neglect to update this value?

Hmm, no (or I don't understand what you mean.) This is per-segment blend state
(will add a comment about that as requested), so it should really only be used
by blendSegments() below and hence it doesn't matter if it's not updated if
anything above it return false.

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
File Source/core/svg/SVGPathBlender.h (right):

https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
Source/core/svg/SVGPathBlender.h:74: bool m_typesAreEqual;
On 2015/04/01 00:03:49, pdr wrote:
> WDYT about a comment here saying that these 3 bools are for the current from
and
> to segments?

Added comment along those lines.

[pdr., 2015-04-01 21:39:37]

On 2015/04/01 at 09:15:55, fs wrote:
>
https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
> File Source/core/svg/SVGPathBlender.cpp (right):
> 
>
https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
> Source/core/svg/SVGPathBlender.cpp:324: m_fromIsAbsolute =
isAbsolutePathSegType(fromSeg.command);
> On 2015/04/01 00:03:49, pdr wrote:
> > If m_typesAreEqual is false, won't we neglect to update this value?
> 
> Hmm, no (or I don't understand what you mean.) This is per-segment blend state
(will add a comment about that as requested), so it should really only be used
by blendSegments() below and hence it doesn't matter if it's not updated if
anything above it return false.
> 
>
https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
> File Source/core/svg/SVGPathBlender.h (right):
> 
>
https://codereview.chromium.org/1048913004/diff/1/Source/core/svg/SVGPathBlen...
> Source/core/svg/SVGPathBlender.h:74: bool m_typesAreEqual;
> On 2015/04/01 00:03:49, pdr wrote:
> > WDYT about a comment here saying that these 3 bools are for the current from
and
> > to segments?
> 
> Added comment along those lines.

LGTM

[fs, 2015-04-02 08:18:37]

The CQ bit was checked by fs@opera.com

[commit-bot: I haz the power, 2015-04-02 08:19:13]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048913004/60001

[commit-bot: I haz the power, 2015-04-02 08:22:50]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=193009