Issue 1048913003: tools/gn: don't allow trailing junk or non-literals in "value" conversion

Issue 1048913003: tools/gn: don't allow trailing junk or non-literals in "value" conversion (Closed)

Created:
5 years, 8 months ago by mdempsky

Modified:
5 years, 8 months ago

Reviewers:
brettw

CC:
chromium-reviews, tfarina, Dirk Pranke, scottmg

Base URL:
https://chromium.googlesource.com/chromium/src.git@master

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

tools/gn: don't allow trailing junk or non-literals in "value" conversion See also discussion on gn-dev: https://groups.google.com/a/chromium.org/d/msg/gn-dev/hHRC1HuWBo8/drOd5dTvO5oJ Committed: https://crrev.com/5557a417ceec6573401493c0760ff914e75795a8 Cr-Commit-Position: refs/heads/master@{#323146}

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+59 lines, -29 lines)			Patch
M	tools/gn/input_conversion.cc	View		2 chunks	+1 line, -9 lines	0 comments	Download
M	tools/gn/input_conversion_unittest.cc	View	1	1 chunk	+24 lines, -17 lines	0 comments	Download
M	tools/gn/parser.h	View		1 chunk	+5 lines, -1 line	0 comments	Download
M	tools/gn/parser.cc	View		2 chunks	+29 lines, -2 lines	0 comments	Download

Total messages: 8 (3 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048913003/20001

5 years, 8 months ago (2015-03-31 23:13:47 UTC) #6

commit-bot: I haz the power

5 years, 8 months ago (2015-04-01 00:02:51 UTC) #8

Message was sent while issue was closed.

Patchset 2 (id:??) landed as
https://crrev.com/5557a417ceec6573401493c0760ff914e75795a8
Cr-Commit-Position: refs/heads/master@{#323146}