Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(23)

Issue 1048863002: Remove android_webview_build conditions from various places. (Closed)

Created:
5 years, 8 months ago by Torne
Modified:
5 years, 8 months ago
CC:
chromium-reviews, feature-media-reviews_chromium.org, cbentzel+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove android_webview_build conditions from various places. Remove various minor android_webview_build references now that we no longer support that build configuration. BUG=440793 Committed: https://crrev.com/fe8398d45c1a88199ec24fe9b77492d295fd3915 Cr-Commit-Position: refs/heads/master@{#324078}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+5 lines, -32 lines) Patch
M media/BUILD.gn View 1 chunk +1 line, -3 lines 0 comments Download
M media/media.gyp View 2 chunks +1 line, -7 lines 0 comments Download
M net/BUILD.gn View 1 chunk +1 line, -4 lines 0 comments Download
M net/net_common.gypi View 1 chunk +1 line, -1 line 0 comments Download
M skia/skia_common.gypi View 1 chunk +0 lines, -7 lines 0 comments Download
M third_party/sqlite/sqlite.gyp View 1 chunk +0 lines, -6 lines 0 comments Download
M tools/imagediff/image_diff.gyp View 1 chunk +1 line, -4 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Torne
+shess for third_party/sqlite +gavinp for net +xhwang for media
5 years, 8 months ago (2015-03-30 17:26:09 UTC) #2
Torne
+djsollen for skia
5 years, 8 months ago (2015-03-30 17:26:32 UTC) #3
Scott Hess - ex-Googler
lgtm for third_party/sqlite/
5 years, 8 months ago (2015-03-30 17:27:18 UTC) #4
xhwang
media/ lgtm
5 years, 8 months ago (2015-03-30 17:28:24 UTC) #5
djsollen
lgtm for skia
5 years, 8 months ago (2015-03-30 18:15:23 UTC) #6
djsollen
lgtm for skia
5 years, 8 months ago (2015-03-30 18:15:23 UTC) #7
Torne
+rsleevi for net/
5 years, 8 months ago (2015-04-07 15:06:15 UTC) #9
Ryan Sleevi
net LGTM
5 years, 8 months ago (2015-04-07 17:46:34 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048863002/1
5 years, 8 months ago (2015-04-07 17:48:31 UTC) #12
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 8 months ago (2015-04-07 18:47:41 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-07 18:48:36 UTC) #14
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/fe8398d45c1a88199ec24fe9b77492d295fd3915
Cr-Commit-Position: refs/heads/master@{#324078}

Powered by Google App Engine
This is Rietveld 408576698