Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Issue 104883006: FunctionLiteral has work to do in the typing phase. (Closed)

Created:
7 years ago by mvstanton
Modified:
6 years, 11 months ago
Reviewers:
Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

FunctionLiteral has work to do in the typing phase. In crankshaft, we searched un-optimized code for a SharedFunctionInfo that matches the FunctionLiteral we are processing. Ideally, this work should be done in the typing phase. R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18508

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+25 lines, -21 lines) Patch
M src/ast.h View 3 chunks +6 lines, -0 lines 0 comments Download
M src/ast.cc View 1 chunk +17 lines, -0 lines 0 comments Download
M src/hydrogen.cc View 1 chunk +1 line, -21 lines 0 comments Download
M src/typing.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
mvstanton
Hi Jakob, here is something we chatted about before Christmas. PTAL, thx. --Michael
6 years, 11 months ago (2014-01-07 09:50:56 UTC) #1
Jakob Kummerow
lgtm
6 years, 11 months ago (2014-01-09 07:52:36 UTC) #2
mvstanton
6 years, 11 months ago (2014-01-09 09:00:29 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r18508 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698