Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issue 1048803003: Revert of New UMA settings fragment for Chrome on Android. (Closed)

Created:
5 years, 8 months ago by gayane -on leave until 09-2017
Modified:
5 years, 8 months ago
CC:
asvitkine+watch_chromium.org, cbentzel+watch_chromium.org, chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of New UMA settings fragment for Chrome on Android. (patchset #9 id:520001 of https://codereview.chromium.org/978623002/) Reason for revert: reverting back to fix crashes during Release tests crbug.com/470016 crbug.com/470062 Original issue's description: > New UMA settings fragment for Chrome on Android. > > This CL is part of new UMA upload logic. The change is for getting more usage data for Chrome users who exclusively use wireless networks. For that, a new binary on/off-switch is added instead of previous three-option model. However, the upload logic is changed on Android to reduce the data usage. > > The new binary switch is also connected to a different pref then previous switch. For the beginning the new settings UI would be enabled for users assigned to experimental group. > > BUG=455847 > > Committed: https://crrev.com/c68d47f75c20971faee1b04d896bf25482aa2b03 > Cr-Commit-Position: refs/heads/master@{#321575} TBR=nyquist@chromium.org,asvitkine@chromium.org,dfalcantara@chromium.org,holte@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=455847 Committed: https://crrev.com/8272191fccbfffae4c7fa0651dbda1bfe483526c Cr-Commit-Position: refs/heads/master@{#322823}

Patch Set 1 #

Patch Set 2 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+67 lines, -400 lines) Patch
M chrome/android/java/res/xml/privacy_preferences.xml View 1 1 chunk +0 lines, -4 lines 0 comments Download
D chrome/android/java/res/xml/usage_and_crash_reports_preferences.xml View 1 1 chunk +0 lines, -24 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/firstrun/FirstRunGlueImpl.java View 1 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/metrics/UmaSessionStats.java View 1 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/PrefServiceBridge.java View 1 6 chunks +3 lines, -55 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferences.java View 1 7 chunks +14 lines, -36 lines 0 comments Download
M chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManager.java View 1 5 chunks +20 lines, -75 lines 0 comments Download
D chrome/android/java/src/org/chromium/chrome/browser/preferences/privacy/UsageAndCrashReportsPreferenceFragment.java View 1 1 chunk +0 lines, -50 lines 0 comments Download
M chrome/android/java/strings/android_chrome_strings.grd View 1 2 chunks +1 line, -12 lines 0 comments Download
M chrome/android/javatests/src/org/chromium/chrome/browser/preferences/privacy/PrivacyPreferencesManagerTest.java View 1 6 chunks +25 lines, -123 lines 0 comments Download
M chrome/browser/android/preferences/pref_service_bridge.cc View 1 1 chunk +0 lines, -17 lines 0 comments Download

Messages

Total messages: 16 (7 generated)
gayane -on leave until 09-2017
Created Revert of New UMA settings fragment for Chrome on Android.
5 years, 8 months ago (2015-03-30 14:58:13 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048803003/1
5 years, 8 months ago (2015-03-30 14:58:30 UTC) #2
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 8 months ago (2015-03-30 14:58:33 UTC) #4
Alexei Svitkine (slow)
lgtm
5 years, 8 months ago (2015-03-30 15:15:17 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048803003/1
5 years, 8 months ago (2015-03-30 15:16:04 UTC) #7
commit-bot: I haz the power
Failed to apply patch for chrome/browser/android/preferences/pref_service_bridge.cc: While running git apply --index -3 -p1; error: patch ...
5 years, 8 months ago (2015-03-30 15:16:41 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048803003/240001
5 years, 8 months ago (2015-03-30 18:59:49 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:240001)
5 years, 8 months ago (2015-03-30 19:01:36 UTC) #15
commit-bot: I haz the power
5 years, 8 months ago (2015-03-30 19:02:44 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/8272191fccbfffae4c7fa0651dbda1bfe483526c
Cr-Commit-Position: refs/heads/master@{#322823}

Powered by Google App Engine
This is Rietveld 408576698