Source/core/css/parser/CSSParserFastPaths.cpp - Issue 1048803002: Remove support of nonstandard 'CSSValueCenter' property value for floated element.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/css/parser/CSSParserFastPaths.cpp

Issue 1048803002: Remove support of nonstandard 'CSSValueCenter' property value for floated element. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 9 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/css/parser/CSSParserFastPaths.cpp

diff --git a/Source/core/css/parser/CSSParserFastPaths.cpp b/Source/core/css/parser/CSSParserFastPaths.cpp

index 5dba684a3526f1ce8a86936978b05fc455ace11b..c207d9b2a9538e69cbd08f04744f4d527955010f 100644

--- a/Source/core/css/parser/CSSParserFastPaths.cpp

+++ b/Source/core/css/parser/CSSParserFastPaths.cpp

@@ -211,7 +211,7 @@ bool CSSParserFastPaths::isValidKeywordPropertyAndValue(CSSPropertyID propertyId

case CSSPropertyEmptyCells: // show | hide

return valueID == CSSValueShow || valueID == CSSValueHide;

case CSSPropertyFloat: // left | right | none | center (for buggy CSS, maps to none)

davve 2015/03/30 16:19:25 I suppose it makes sense to update the comment too

Abhijeet Kandalkar Slow 2015/03/31 05:04:19 Done.

- return valueID == CSSValueLeft || valueID == CSSValueRight || valueID == CSSValueNone || valueID == CSSValueCenter;

+ return valueID == CSSValueLeft || valueID == CSSValueRight || valueID == CSSValueNone;

case CSSPropertyFontStyle: // normal | italic | oblique

return valueID == CSSValueNormal || valueID == CSSValueItalic || valueID == CSSValueOblique;

« LayoutTests/fast/block/float/override-property-float.html ('K') | « Source/core/css/CSSPrimitiveValueMappings.h ('k') | no next file » | no next file with comments »