Remove support of nonstandard 'CSSValueCenter' property value for floated element.

Remove support of nonstandard 'CSSValueCenter' property value for
floated element

Blink supports nonstandard 'CSSValueCenter' property for floated elements
whose behavior is similar to'CSSValueNone'.

Issue is CSSParserFastPaths allowing 'center' and CSSPrimitiveValueMappings
handling it like 'none'.

As per CSS cascading rule, if two declarations have the same weight,
origin and specificity the latter specified wins.
So, 'center' is overriding previously applied value of float property.

As per spec [1], float property doesn't support 'center' value.
So, Blink should stop supporting it.

[1] http://dev.w3.org/csswg/css-box-3/#float

BUG=470633
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=192839

[Abhijeet Kandalkar Slow, 2015-03-30 11:41:37]

abhijeet.k@samsung.com changed reviewers:
+ timloh@chromium.org, vivekg@chromium.org

[Abhijeet Kandalkar Slow, 2015-03-30 11:43:31]

Please review patch.

[davve, 2015-03-30 16:19:24]

davve@opera.com changed reviewers:
+ davve@opera.com

[davve, 2015-03-30 16:19:25]

For fun I git blamed myself all the way to the initial revision of
WebCore/khtml/css/cssparser.cpp and basically the root of the git (CVS) repo,
for hints to what "buggy CSS" might refer too. Didn't find anything.

https://codereview.chromium.org/1048803002/diff/1/Source/core/css/parser/CSSP...
File Source/core/css/parser/CSSParserFastPaths.cpp (left):

https://codereview.chromium.org/1048803002/diff/1/Source/core/css/parser/CSSP...
Source/core/css/parser/CSSParserFastPaths.cpp:213: case CSSPropertyFloat: //
left | right | none | center (for buggy CSS, maps to none)
I suppose it makes sense to update the comment too?

[Timothy Loh, 2015-03-30 23:55:14]

ok lgtm, but fix up the comment that davve@ pointed out.

https://codereview.chromium.org/1048803002/diff/1/LayoutTests/fast/block/floa...
File LayoutTests/fast/block/float/override-property-float.html (right):

https://codereview.chromium.org/1048803002/diff/1/LayoutTests/fast/block/floa...
LayoutTests/fast/block/float/override-property-float.html:9: background:red;
green please :-)

[Abhijeet Kandalkar Slow, 2015-03-31 05:04:19]

@David, Please have look of latest patch.

https://codereview.chromium.org/1048803002/diff/1/LayoutTests/fast/block/floa...
File LayoutTests/fast/block/float/override-property-float.html (right):

https://codereview.chromium.org/1048803002/diff/1/LayoutTests/fast/block/floa...
LayoutTests/fast/block/float/override-property-float.html:9: background:red;
On 2015/03/30 23:55:14, Timothy Loh wrote:
> green please :-)

Done.

https://codereview.chromium.org/1048803002/diff/1/Source/core/css/parser/CSSP...
File Source/core/css/parser/CSSParserFastPaths.cpp (left):

https://codereview.chromium.org/1048803002/diff/1/Source/core/css/parser/CSSP...
Source/core/css/parser/CSSParserFastPaths.cpp:213: case CSSPropertyFloat: //
left | right | none | center (for buggy CSS, maps to none)
On 2015/03/30 16:19:25, David Vest wrote:
> I suppose it makes sense to update the comment too?

Done.

[davve, 2015-03-31 07:32:20]

Non-owner LGTM with nit.

You may also want to clean up the description at least a little:

 * Remove period after description.
 * Remote whitespace in link in footnote.
 * Prefer floated element or float property instead of float element.
 * Nonstandard is written together, AFAICT.

https://codereview.chromium.org/1048803002/diff/20001/LayoutTests/fast/block/...
File LayoutTests/fast/block/float/override-property-float.html (right):

https://codereview.chromium.org/1048803002/diff/20001/LayoutTests/fast/block/...
LayoutTests/fast/block/float/override-property-float.html:19: description('If
this test passes, the red box should be on the right side of page.');
s/red/green/

[Abhijeet Kandalkar Slow, 2015-03-31 08:23:16]

@David : Please rubber stamp this change.

https://codereview.chromium.org/1048803002/diff/20001/LayoutTests/fast/block/...
File LayoutTests/fast/block/float/override-property-float.html (right):

https://codereview.chromium.org/1048803002/diff/20001/LayoutTests/fast/block/...
LayoutTests/fast/block/float/override-property-float.html:19: description('If
this test passes, the red box should be on the right side of page.');
On 2015/03/31 07:32:20, David Vest wrote:
> s/red/green/

Done.

[davve, 2015-03-31 09:20:31]

On 2015/03/31 08:23:16, Abhijeet Kandalkar wrote:
> @David : Please rubber stamp this change.

Better now. Thanks.

[Abhijeet Kandalkar Slow, 2015-03-31 09:36:03]

On 2015/03/31 09:20:31, David Vest wrote:
> On 2015/03/31 08:23:16, Abhijeet Kandalkar wrote:
> > @David : Please rubber stamp this change.
> 
> Better now. Thanks.

Thanks for review.

[Abhijeet Kandalkar Slow, 2015-03-31 09:36:08]

The CQ bit was checked by abhijeet.k@samsung.com

[Abhijeet Kandalkar Slow, 2015-03-31 09:36:08]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
davve@opera.com
Link to the patchset: https://codereview.chromium.org/1048803002/#ps40001
(title: " ")

[commit-bot: I haz the power, 2015-03-31 09:36:23]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048803002/40001

[Abhijeet Kandalkar Slow, 2015-03-31 13:35:40]

On 2015/03/31 09:36:23, I haz the power (commit-bot) wrote:
> CQ is trying da patch. Follow status at
>  https://chromium-cq-status.appspot.com/patch-status/1048803002/40001

Fixed.

[Abhijeet Kandalkar Slow, 2015-03-31 13:35:52]

The CQ bit was checked by abhijeet.k@samsung.com

[Abhijeet Kandalkar Slow, 2015-03-31 13:35:52]

The patchset sent to the CQ was uploaded after l-g-t-m from timloh@chromium.org,
davve@opera.com
Link to the patchset: https://codereview.chromium.org/1048803002/#ps60001
(title: " ")

[commit-bot: I haz the power, 2015-03-31 13:36:00]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048803002/60001

[commit-bot: I haz the power, 2015-03-31 16:01:34]

Committed patchset #4 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=192839