Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3660)

Unified Diff: chrome/browser/ui/cocoa/spinner_view_unittest.mm

Issue 1048733004: Add a Material Design Circular Activity Indicator (Spinner) view for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix two more nits. Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/cocoa/spinner_view_unittest.mm
diff --git a/chrome/browser/ui/cocoa/spinner_view_unittest.mm b/chrome/browser/ui/cocoa/spinner_view_unittest.mm
new file mode 100644
index 0000000000000000000000000000000000000000..93d652c71e4e6a829222aa482757fab0db55efae
--- /dev/null
+++ b/chrome/browser/ui/cocoa/spinner_view_unittest.mm
@@ -0,0 +1,69 @@
+// Copyright 2015 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/cocoa/spinner_view.h"
+
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
+
+@interface SpinnerView (ExposedForTesting)
+
+- (BOOL)isAnimating;
+
+@end
+
+@implementation SpinnerView (ExposedForTesting)
+
+- (BOOL)isAnimating {
+ return isAnimating_;
+}
+
+@end
+
+namespace {
+
+class SpinnerViewTest : public ui::CocoaTest {
+ public:
+ SpinnerViewTest() {
+ CGRect frame = NSMakeRect(0.0, 0.0, 16.0, 16.0);
+ view_.reset([[SpinnerView alloc] initWithFrame:frame]);
+ [[test_window() contentView] addSubview:view_];
+ }
+
+ base::scoped_nsobject<SpinnerView> view_;
+};
+
+TEST_VIEW(SpinnerViewTest, view_)
+
+TEST_F(SpinnerViewTest, StopAnimationOnMiniaturize) {
+ EXPECT_TRUE([view_ isAnimating]);
+
+ [test_window() miniaturize:nil];
+ EXPECT_FALSE([view_ isAnimating]);
+
+ [test_window() deminiaturize:nil];
+ EXPECT_TRUE([view_ isAnimating]);
+}
+
+TEST_F(SpinnerViewTest,
+ StopAnimationOnRemoveFromSuperview) {
+ EXPECT_TRUE([view_ isAnimating]);
+
+ [view_ removeFromSuperview];
+ EXPECT_FALSE([view_ isAnimating]);
+
+ [[test_window() contentView] addSubview:view_];
+ EXPECT_TRUE([view_ isAnimating]);
+}
+
+TEST_F(SpinnerViewTest, StopAnimationOnHidden) {
+ EXPECT_TRUE([view_ isAnimating]);
+
+ [view_ setHidden:YES];
+ EXPECT_FALSE([view_ isAnimating]);
+
+ [view_ setHidden:NO];
+ EXPECT_TRUE([view_ isAnimating]);
+}
+
+} // namespace
Robert Sesek 2015/04/02 19:58:36 nit: two spaces before end-of-line comments

Powered by Google App Engine
This is Rietveld 408576698