Add a Material Design Circular Activity Indicator (Spinner) view for Mac.

chrome/browser/ui/cocoa/spinner_view_unittest.mm

+// Copyright (c) 2015 The Chromium Authors. All rights reserved.

[Robert Sesek, 2015/04/01 16:25:02]

nit: no (c) in new files

[shrike, 2015/04/01 20:55:55]

More copy/paste fallout. Done.

+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "chrome/browser/ui/cocoa/spinner_view.h"
+
+#import "ui/gfx/test/ui_cocoa_test_helper.h"
+
+@interface SpinnerView(ExposedForTesting)

[Robert Sesek, 2015/04/01 16:25:02]

nit: space before (

[shrike, 2015/04/01 20:55:55]

Done.

+
+- (BOOL)is_animating;

[Robert Sesek, 2015/04/01 16:25:02]

naming: isAnimating

[shrike, 2015/04/01 20:55:55]

Done.

+
+@end
+
+@implementation SpinnerView(ExposedForTesting)
+
+- (BOOL)is_animating
+{

[Robert Sesek, 2015/04/01 16:25:02]

nit: goes on previous line

[shrike, 2015/04/01 20:55:55]

Done.

+  return is_animating_;
+}
+
+@end
+
+namespace {
+
+  class SpinnerViewTest : public ui::CocoaTest {

[Robert Sesek, 2015/04/01 16:25:02]

namespace should not be indented

[shrike, 2015/04/01 20:55:55]

Done.

+  public:

[Robert Sesek, 2015/04/01 16:25:03]

nit: indent 1 space

[shrike, 2015/04/01 20:55:55]

Done.

+    SpinnerViewTest() {
+      CGRect frame = NSMakeRect(0.0, 0.0, 16.0, 16.0);
+      view_.reset([[SpinnerView alloc] initWithFrame:frame]);
+      [[test_window() contentView] addSubview:view_];
+    }
+
+    base::scoped_nsobject<SpinnerView> view_;
+  };
+
+  TEST_VIEW(SpinnerViewTest, view_)
+
+  TEST_F(SpinnerViewTest, StopAnimationOnMiniaturize) {
+    EXPECT_TRUE([view_ is_animating]);
+
+    [test_window() miniaturize:nil];
+    EXPECT_FALSE([view_ is_animating]);
+
+    [test_window() deminiaturize:nil];
+    EXPECT_TRUE([view_ is_animating]);
+  }
+
+  TEST_F(SpinnerViewTest,
+         StopAnimationOnRemoveFromSuperview) {
+    EXPECT_TRUE([view_ is_animating]);
+
+    [view_ removeFromSuperview];
+    EXPECT_FALSE([view_ is_animating]);
+
+    [[test_window() contentView] addSubview:view_];
+    EXPECT_TRUE([view_ is_animating]);
+  }
+
+  TEST_F(SpinnerViewTest, StopAnimationOnHidden) {
+    EXPECT_TRUE([view_ is_animating]);
+
+    [view_ setHidden:YES];
+    EXPECT_FALSE([view_ is_animating]);
+
+    [view_ setHidden:NO];
+    EXPECT_TRUE([view_ is_animating]);
+  }
+}

[Robert Sesek, 2015/04/01 16:25:02]

nit: "  // namespace" comment at the end

[shrike, 2015/04/01 20:55:55]

Done.

+

[Robert Sesek, 2015/04/01 16:25:02]

nit: extra blakn ilne

[shrike, 2015/04/01 20:55:55]

Done.