chrome/browser/ui/cocoa/circular_activity_indicator_view.h - Issue 1048733004: Add a Material Design Circular Activity Indicator (Spinner) view for Mac.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/ui/cocoa/circular_activity_indicator_view.h

Issue 1048733004: Add a Material Design Circular Activity Indicator (Spinner) view for Mac. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix nits and address other comments. Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

OLD	NEW
(Empty)
	1 // Copyright 2015 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef CHROME_BROWSER_UI_COCOA_CIRCULAR_ACTIVITY_INDICATOR_VIEW_H_

	6 #define CHROME_BROWSER_UI_COCOA_CIRCULAR_ACTIVITY_INDICATOR_VIEW_H_

	7

	8 #import <Cocoa/Cocoa.h>

	9

	10 #include "base/mac/scoped_nsobject.h"

	11

	12 @class CAAnimationGroup;

	13 @class CAShapeLayer;

	14

	15 @interface CircularActivityIndicatorView : NSView {

	16 bool is_animating_;
	groby-ooo-7-16 2015/03/31 23:07:01 nit: Mark @private, please. nit: Mark @private, please. shrike 2015/04/01 15:30:45 Done. Show quoted text On 2015/03/31 23:07:01, groby wrote: > nit: Mark @private, please. Done.
	17 }

	18

	19 @end

	20

	21 #endif // CHROME_BROWSER_UI_COCOA_CIRCULAR_ACTIVITY_INDICATOR_VIEW_H_

OLD	NEW

« no previous file with comments | « no previous file | chrome/browser/ui/cocoa/circular_activity_indicator_view.mm » ('j') | chrome/browser/ui/cocoa/circular_activity_indicator_view.mm » ('J')