Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(233)

Unified Diff: Source/bindings/v8/V8PerIsolateData.cpp

Issue 104873018: Remove raw DOM templates from V8 bindings (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 12 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/bindings/v8/V8PerIsolateData.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/bindings/v8/V8PerIsolateData.cpp
diff --git a/Source/bindings/v8/V8PerIsolateData.cpp b/Source/bindings/v8/V8PerIsolateData.cpp
index 10064bc2ddef9fd3041dae2402af2d539ab9ffc2..34affcd98463f621fce967dd544c47e74ed58aa4 100644
--- a/Source/bindings/v8/V8PerIsolateData.cpp
+++ b/Source/bindings/v8/V8PerIsolateData.cpp
@@ -117,19 +117,6 @@ void V8PerIsolateData::setPrivateTemplate(WrapperWorldType currentWorldType, voi
templateMap(currentWorldType).add(privatePointer, UnsafePersistent<v8::FunctionTemplate>(m_isolate, templ));
}
-v8::Handle<v8::FunctionTemplate> V8PerIsolateData::rawDOMTemplate(const WrapperTypeInfo* info, WrapperWorldType currentWorldType)
-{
- TemplateMap& templates = rawDOMTemplateMap(currentWorldType);
- TemplateMap::iterator result = templates.find(info);
- if (result != templates.end())
- return result->value.newLocal(m_isolate);
-
- v8::EscapableHandleScope handleScope(m_isolate);
- v8::Local<v8::FunctionTemplate> templ = createRawTemplate(m_isolate);
- templates.add(info, UnsafePersistent<v8::FunctionTemplate>(m_isolate, templ));
- return handleScope.Escape(templ);
-}
-
v8::Local<v8::Context> V8PerIsolateData::ensureRegexContext()
{
if (m_regexContext.isEmpty()) {
@@ -141,7 +128,7 @@ v8::Local<v8::Context> V8PerIsolateData::ensureRegexContext()
bool V8PerIsolateData::hasInstance(const WrapperTypeInfo* info, v8::Handle<v8::Value> value, WrapperWorldType currentWorldType)
{
- TemplateMap& templates = rawDOMTemplateMap(currentWorldType);
+ TemplateMap& templates = templateMap(currentWorldType);
TemplateMap::iterator result = templates.find(info);
if (result == templates.end())
return false;
« no previous file with comments | « Source/bindings/v8/V8PerIsolateData.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698