Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(407)

Issue 104873018: Remove raw DOM templates from V8 bindings (Closed)

Created:
6 years, 11 months ago by haraken
Modified:
6 years, 11 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, marja+watch_chromium.org, adamk+blink_chromium.org, haraken, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Remove raw DOM templates from V8 bindings - I don't think we need to distinguish DOM templates from raw DOM templates. - A raw DOM template and a DOM template are the same objects. The only difference between the two templates is whether we require the template to install DOM attributes/methods or not. When we call rawDOMTemplate(), it means "Please return a DOM template. It's OK if the DOM template hasn't yet installed DOM attributes/methods". On the other hand, when we call domTemplate(), it means "Please return a DOM template after installing DOM attributes/methods". - Thus it is worth having both rawDOMTemplate() and domTemplate() only if there are situations where we need a DOM template that hasn't yet installed DOM attributes/methods. However, as far as I read the code, there wouldn't be many situations like that, because we normally call domTemplate() and install DOM attributes/methods when creating the first wrapper of the DOM object. - In summary, there wouldn't be a situation where we gain performance by having rawDOMTemplate(). Given the above, this CL removes rawDOMTemplate(). Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164451

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -148 lines) Patch
M Source/bindings/scripts/code_generator_v8.pm View 1 2 3 7 chunks +8 lines, -8 lines 0 comments Download
M Source/bindings/tests/results/V8SupportTestInterface.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestCustomAccessors.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestEventTarget.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestException.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterface.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp View 14 chunks +14 lines, -14 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEmpty.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython2.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestInterfacePython3.cpp View 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestNode.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObject.cpp View 1 2 3 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestObjectPython.cpp View 1 2 3 4 chunks +4 lines, -4 lines 0 comments Download
M Source/bindings/tests/results/V8TestTypedefs.cpp View 3 chunks +3 lines, -4 lines 0 comments Download
M Source/bindings/v8/V8Binding.h View 1 2 3 1 chunk +0 lines, -2 lines 0 comments Download
M Source/bindings/v8/V8Binding.cpp View 1 2 3 1 chunk +0 lines, -7 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.h View 3 chunks +0 lines, -11 lines 0 comments Download
M Source/bindings/v8/V8PerIsolateData.cpp View 2 chunks +1 line, -14 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
haraken
PTAL.
6 years, 11 months ago (2014-01-01 17:25:50 UTC) #1
jochen (gone - plz use gerrit)
lgtm
6 years, 11 months ago (2014-01-03 11:20:38 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/haraken@chromium.org/104873018/300001
6 years, 11 months ago (2014-01-03 14:16:34 UTC) #3
commit-bot: I haz the power
6 years, 11 months ago (2014-01-03 14:22:07 UTC) #4
Message was sent while issue was closed.
Change committed as 164451

Powered by Google App Engine
This is Rietveld 408576698