|
|
Remove raw DOM templates from V8 bindings
- I don't think we need to distinguish DOM templates from raw DOM templates.
- A raw DOM template and a DOM template are the same objects. The only difference between the two templates is whether we require the template to install DOM attributes/methods or not. When we call rawDOMTemplate(), it means "Please return a DOM template. It's OK if the DOM template hasn't yet installed DOM attributes/methods". On the other hand, when we call domTemplate(), it means "Please return a DOM template after installing DOM attributes/methods".
- Thus it is worth having both rawDOMTemplate() and domTemplate() only if there are situations where we need a DOM template that hasn't yet installed DOM attributes/methods. However, as far as I read the code, there wouldn't be many situations like that, because we normally call domTemplate() and install DOM attributes/methods when creating the first wrapper of the DOM object.
- In summary, there wouldn't be a situation where we gain performance by having rawDOMTemplate().
Given the above, this CL removes rawDOMTemplate().
Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=164451
|
Unified diffs |
Side-by-side diffs |
Delta from patch set |
Stats (+103 lines, -148 lines) |
Patch |
 |
M |
Source/bindings/scripts/code_generator_v8.pm
|
View
|
1
2
3
|
7 chunks |
+8 lines, -8 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8SupportTestInterface.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestCustomAccessors.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestEventTarget.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestException.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterface.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceCheckSecurity.cpp
|
View
|
|
14 chunks |
+14 lines, -14 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor2.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceConstructor3.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceCustomConstructor.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceDoNotCheckConstants.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEmpty.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEventConstructor.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceEventTarget.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceImplementedAs.cpp
|
View
|
1
2
3
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNamedConstructor.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfaceNamedConstructor2.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython2.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestInterfacePython3.cpp
|
View
|
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestNode.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestObject.cpp
|
View
|
1
2
3
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestObjectPython.cpp
|
View
|
1
2
3
|
4 chunks |
+4 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/tests/results/V8TestTypedefs.cpp
|
View
|
|
3 chunks |
+3 lines, -4 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/v8/V8Binding.h
|
View
|
1
2
3
|
1 chunk |
+0 lines, -2 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/v8/V8Binding.cpp
|
View
|
1
2
3
|
1 chunk |
+0 lines, -7 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/v8/V8PerIsolateData.h
|
View
|
|
3 chunks |
+0 lines, -11 lines |
0 comments
|
Download
|
 |
M |
Source/bindings/v8/V8PerIsolateData.cpp
|
View
|
|
2 chunks |
+1 line, -14 lines |
0 comments
|
Download
|
Total messages: 4 (0 generated)
|