[Cleanup] Remove the obsolete Prerender field trial.

[Cleanup] Remove the obsolete Prerender field trial.

BUG=470630
TEST=none
R=davidben@chromium.org
TBR=yfriedman@chromium.org

Committed: https://crrev.com/4fecce00601126187231f7dd8a2f17c9b142b827
Cr-Commit-Position: refs/heads/master@{#323125}

[Ilya Sherman, 2015-03-30 06:41:38]

PTAL.  There's a bunch more cleanup possible here, but this was about all that I
felt comfortable with doing, given that I do not know the code very well.  If
these trials are truly obsolete, I'd encourage you to take some time to prune
what looks like a lot of dead code from the codebase.  Thanks :)

[davidben, 2015-03-30 18:23:22]

davidben@chromium.org changed reviewers:
+ davidben@chromium.org

[davidben, 2015-03-30 18:23:23]

(tburkard isn't working on Chrome anymore. I'm probably the closest thing
prerender has to anyone working on it these days... we should maybe prune the
OWNERS...)

If we can prune all the code relating to this stuff, I will *happily* do so.
Looks like this lets us remove the entire local predictor? zhenw (CC'd) was
talking many months back about reusing some of it for a prefetch mechanism. But
that code has grown organically out of being so many different things, so I'm
tempted to push for dropping and rewriting (or at least rereviewing) it.

Either way, this just removes the experiments, so this lgtm! I'll sync with
zhenw before removing the rest.

[Zhen Wang, 2015-03-30 19:35:48]

The smart prefetch experiment never got a chance to run due to the network
preference issue. And I don't see any sign of being able to run it in the
near future. Feel free to clean it up. If the network preference issue is
resolved, I can revisit it and get it re-reviewed.

Best
-Zhen

On Mon, Mar 30, 2015 at 11:23 AM, <davidben@chromium.org> wrote:

> (tburkard isn't working on Chrome anymore. I'm probably the closest thing
> prerender has to anyone working on it these days... we should maybe prune
> the
> OWNERS...)
>
> If we can prune all the code relating to this stuff, I will *happily* do
> so.
> Looks like this lets us remove the entire local predictor? zhenw (CC'd) was
> talking many months back about reusing some of it for a prefetch
> mechanism. But
> that code has grown organically out of being so many different things, so
> I'm
> tempted to push for dropping and rewriting (or at least rereviewing) it.
>
> Either way, this just removes the experiments, so this lgtm! I'll sync with
> zhenw before removing the rest.
>
> https://codereview.chromium.org/1048723003/
>

To unsubscribe from this group and stop receiving emails from it, send an email
to chromium-reviews+unsubscribe@chromium.org.

[davidben, 2015-03-30 19:46:04]

On 2015/03/30 19:35:48, Zhen Wang (OOO) wrote:
> The smart prefetch experiment never got a chance to run due to the network
> preference issue. And I don't see any sign of being able to run it in the
> near future. Feel free to clean it up. If the network preference issue is
> resolved, I can revisit it and get it re-reviewed.

Sounds good. Thanks for following up! (I noticed you were OOO and figured I'd
wait till you were back before pestering you.)

[davidben, 2015-03-30 20:21:23]

https://codereview.chromium.org/1048723003/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_field_trial.cc (left):

https://codereview.chromium.org/1048723003/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_field_trial.cc:26: using
base::FieldTrialList;
This one is still used in IsOmniboxEnabled.

[Ilya Sherman, 2015-03-30 23:47:10]

isherman@chromium.org changed reviewers:
+ yfriedman@chromium.org

[Ilya Sherman, 2015-03-30 23:47:38]

TBR Yaron for flag removal from chrome/browser/android/chrome_startup_flags.cc

https://codereview.chromium.org/1048723003/diff/1/chrome/browser/prerender/pr...
File chrome/browser/prerender/prerender_field_trial.cc (left):

https://codereview.chromium.org/1048723003/diff/1/chrome/browser/prerender/pr...
chrome/browser/prerender/prerender_field_trial.cc:26: using
base::FieldTrialList;
On 2015/03/30 20:21:23, David Benjamin wrote:
> This one is still used in IsOmniboxEnabled.

Done.

[Ilya Sherman, 2015-03-30 23:47:42]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2015-03-30 23:47:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1048723003/#ps20001
(title: "Fix compile")

[commit-bot: I haz the power, 2015-03-30 23:48:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048723003/20001

[commit-bot: I haz the power, 2015-03-31 00:24:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 00:24:08]

Try jobs failed on following builders:
  linux_chromium_gn_chromeos_rel on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Ilya Sherman, 2015-03-31 00:25:38]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2015-03-31 00:25:38]

The patchset sent to the CQ was uploaded after l-g-t-m from
davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1048723003/#ps40001
(title: "Remove unused variables")

[commit-bot: I haz the power, 2015-03-31 00:26:22]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048723003/40001

[commit-bot: I haz the power, 2015-03-31 02:45:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-03-31 02:45:25]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_ng on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yaron, 2015-03-31 14:01:31]

lgtm

[Ilya Sherman, 2015-03-31 21:08:01]

The CQ bit was checked by isherman@chromium.org

[Ilya Sherman, 2015-03-31 21:08:01]

The patchset sent to the CQ was uploaded after l-g-t-m from
yfriedman@chromium.org, davidben@chromium.org
Link to the patchset: https://codereview.chromium.org/1048723003/#ps60001
(title: "Remove obsolete browser tests")

[commit-bot: I haz the power, 2015-03-31 21:09:57]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048723003/60001

[commit-bot: I haz the power, 2015-03-31 22:11:22]

Committed patchset #4 (id:60001)

[commit-bot: I haz the power, 2015-03-31 22:12:18]

Patchset 4 (id:??) landed as
https://crrev.com/4fecce00601126187231f7dd8a2f17c9b142b827
Cr-Commit-Position: refs/heads/master@{#323125}