Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(93)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1048713003: Revert of WIP: Added support for giflib, updated jpeg and png (Closed)

Created:
5 years, 8 months ago by borenet
Modified:
5 years, 8 months ago
Reviewers:
msarett, scroggo, djsollen
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of WIP: Added support for giflib, updated jpeg and png (patchset #8 id:260001 of https://codereview.chromium.org/1038863003/) Reason for revert: Trying out revert to see if it fixes Android bots. Original issue's description: > WIP: Added support for giflib, updated jpeg and png > > BUG=skia:3257 > > Committed: https://skia.googlesource.com/skia/+/255dcd11992ebe74eb54202c48cf5394d33a8ce6 TBR=djsollen@google.com,scroggo@google.com,msarett@google.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/00c95098c327c0c28578f61b373a41b98f2bf894

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+114 lines, -81 lines) Patch
M DEPS View 2 chunks +6 lines, -4 lines 0 comments Download
M gyp/android_deps.gyp View 2 chunks +12 lines, -1 line 0 comments Download
A gyp/chromeos_deps.gyp View 1 chunk +13 lines, -0 lines 0 comments Download
M gyp/common_variables.gypi View 2 chunks +8 lines, -0 lines 0 comments Download
M gyp/giflib.gyp View 2 chunks +9 lines, -10 lines 0 comments Download
M gyp/images.gyp View 6 chunks +6 lines, -10 lines 0 comments Download
M platform_tools/android/gyp/dependencies.gypi View 4 chunks +25 lines, -56 lines 0 comments Download
A platform_tools/chromeos/gyp/dependencies.gypi View 1 chunk +35 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (1 generated)
borenet
Created Revert of WIP: Added support for giflib, updated jpeg and png
5 years, 8 months ago (2015-03-30 11:51:55 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048713003/1
5 years, 8 months ago (2015-03-30 12:51:38 UTC) #3
commit-bot: I haz the power
Committed patchset #1 (id:1) as https://skia.googlesource.com/skia/+/00c95098c327c0c28578f61b373a41b98f2bf894
5 years, 8 months ago (2015-03-30 12:51:53 UTC) #4
scroggo
5 years, 8 months ago (2015-03-30 14:34:04 UTC) #5
Message was sent while issue was closed. 
On 2015/03/30 12:51:53, I haz the power (commit-bot) wrote:
> Committed patchset #1 (id:1) as
> https://skia.googlesource.com/skia/+/00c95098c327c0c28578f61b373a41b98f2bf894

I think the only piece that broke was using a newer version of libpng. Matt, go
ahead and reland this change without updating libpng.

Derek, isn't the libpng we upgraded to the version currently used by Android? It
seems concerning that it is causing failures :( Maybe these images are too small
to use subset decoding (at least some that failed are 32 x 32 - we certainly
*shouldn't* be using subset decoding on such small images, but I think Android
does...). Further, if they fail due to being too small, buildTileIndex should
fail instead of decodeSubset (note: the bots do not consider the former a
failure, while they do consider the latter a failure).

Powered by Google App Engine
This is Rietveld 408576698