Upstream ios/web/web_state/ui support classes

Upstream ios/web/web_state/ui support classes

Upstreams web_state/ui except for WebController-specific code, since
that's tangled with lot of of things that still need to be upstreamed.

Does not include unit tests, as those require WebController creation.

BUG=464810
Committed: https://crrev.com/9b7ad6617af141958e0588273c68eff8bbbd5ede
Cr-Commit-Position: refs/heads/master@{#322776}

[stuartmorgan, 2015-03-29 07:02:45]

stuartmorgan@chromium.org changed reviewers:
+ eugenebut@chromium.org

[Eugene But (OOO till 7-30), 2015-03-30 05:03:58]

lgtm, all suggestions are actually optional

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
File ios/web/web_state/ui/crw_debug_web_view.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
ios/web/web_state/ui/crw_debug_web_view.h:24: - (void)webView:(WebView *)webView
didParseSource:(NSString*)source
NIT: No space before *

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
ios/web/web_state/ui/crw_debug_web_view.h:53: - (void)webView:(id)sender
didClearWindowObject:(id)windowObject
Optional NIT: align :

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
File ios/web/web_state/ui/crw_debug_web_view.mm (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
ios/web/web_state/ui/crw_debug_web_view.mm:47: - (void)webView:(WebView
*)webView didParseSource:(NSString*)source
NIT: No space before *

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_script_message_router.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_script_message_router.h:5: #ifndef
IOS_WEB_WEB_STATE_UI_CRW_WK_SCRIPT_MESSAGE_ROUTER_H_
Optional: I think I can remove this class at all very soon. Could you please
exclude if from this patch to avoid unnecessary churn.

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_simple_web_view_controller.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_simple_web_view_controller.h:13: // TODO(shreyasv):
Make this subscribe to CRWSimpleWebView and implement
NIT: I think this comment is not valid anymore.

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_simple_web_view_controller.mm (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_simple_web_view_controller.mm:87: -
(void)observeValueForKeyPath:(NSString *)keyPath
NIT: No space before *

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_simple_web_view_controller.mm:89:
change:(NSDictionary *)change
ditto

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_simple_web_view_controller.mm:90: context:(void
*)context {
ditto

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/wk_web...
File ios/web/web_state/ui/wk_web_view_configuration_provider.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/wk_web...
ios/web/web_state/ui/wk_web_view_configuration_provider.h:40:
CRWWKScriptMessageRouter* GetScriptMessageRouter();
Optional: Could you please exclude this file from CL. I will upstream it after I
remove CRWWKScriptMessageRouter.

[stuartmorgan, 2015-03-30 14:17:58]

Since I was making changes and thus will need to cherry-pick this anyway, I went
ahead and clang formatted it. It did a couple of odd things, but nothing
terrible (except the usual 8-space-indent-on-declaration mangling, which I
undid)

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
File ios/web/web_state/ui/crw_debug_web_view.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
ios/web/web_state/ui/crw_debug_web_view.h:24: - (void)webView:(WebView *)webView
didParseSource:(NSString*)source
On 2015/03/30 05:03:58, eugenebut wrote:
> NIT: No space before *

Done. Also fixed the missing break before didParseSource:

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
ios/web/web_state/ui/crw_debug_web_view.h:53: - (void)webView:(id)sender
didClearWindowObject:(id)windowObject
On 2015/03/30 05:03:58, eugenebut wrote:
> Optional NIT: align :

Done, and also fixed the missing break.

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
File ios/web/web_state/ui/crw_debug_web_view.mm (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_de...
ios/web/web_state/ui/crw_debug_web_view.mm:47: - (void)webView:(WebView
*)webView didParseSource:(NSString*)source
On 2015/03/30 05:03:58, eugenebut wrote:
> NIT: No space before *

Done.

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_script_message_router.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_script_message_router.h:5: #ifndef
IOS_WEB_WEB_STATE_UI_CRW_WK_SCRIPT_MESSAGE_ROUTER_H_
On 2015/03/30 05:03:58, eugenebut wrote:
> Optional: I think I can remove this class at all very soon. Could you please
> exclude if from this patch to avoid unnecessary churn.

Done.

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
File ios/web/web_state/ui/crw_wk_simple_web_view_controller.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/crw_wk...
ios/web/web_state/ui/crw_wk_simple_web_view_controller.h:13: // TODO(shreyasv):
Make this subscribe to CRWSimpleWebView and implement
On 2015/03/30 05:03:58, eugenebut wrote:
> NIT: I think this comment is not valid anymore.

Removed.

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/wk_web...
File ios/web/web_state/ui/wk_web_view_configuration_provider.h (right):

https://codereview.chromium.org/1048613002/diff/1/ios/web/web_state/ui/wk_web...
ios/web/web_state/ui/wk_web_view_configuration_provider.h:40:
CRWWKScriptMessageRouter* GetScriptMessageRouter();
On 2015/03/30 05:03:58, eugenebut wrote:
> Optional: Could you please exclude this file from CL. I will upstream it after
I
> remove CRWWKScriptMessageRouter.

Done.

[stuartmorgan, 2015-03-30 14:30:17]

The CQ bit was checked by stuartmorgan@chromium.org

[stuartmorgan, 2015-03-30 14:30:18]

The patchset sent to the CQ was uploaded after l-g-t-m from
eugenebut@chromium.org
Link to the patchset: https://codereview.chromium.org/1048613002/#ps40001
(title: "clang format")

[commit-bot: I haz the power, 2015-03-30 14:30:25]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1048613002/40001

[commit-bot: I haz the power, 2015-03-30 14:52:16]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-03-30 14:52:52]

Patchset 3 (id:??) landed as
https://crrev.com/9b7ad6617af141958e0588273c68eff8bbbd5ede
Cr-Commit-Position: refs/heads/master@{#322776}