Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(49)

Issue 104853005: Accept displacement with no displacement input (Closed)

Created:
7 years ago by sugoi1
Modified:
7 years ago
CC:
skia-review_googlegroups.com
Base URL:
https://skia.googlesource.com/skia.git@master
Visibility:
Public.

Description

Accept displacement with no displacement input BUG= Committed: http://code.google.com/p/skia/source/detail?r=12773

Patch Set 1 #

Patch Set 2 : Added test #

Patch Set 3 : Update to ToT #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -3 lines) Patch
M expectations/gm/ignored-tests.txt View 1 2 1 chunk +3 lines, -0 lines 0 comments Download
M gm/displacement.cpp View 1 2 chunks +10 lines, -0 lines 0 comments Download
M src/effects/SkDisplacementMapEffect.cpp View 1 chunk +2 lines, -3 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
sugoi
7 years ago (2013-12-18 16:34:34 UTC) #1
sugoi
7 years ago (2013-12-18 20:55:49 UTC) #2
Stephen White
Tests?
7 years ago (2013-12-19 14:55:42 UTC) #3
sugoi
On 2013/12/19 14:55:42, Stephen White wrote: > Tests? Done
7 years ago (2013-12-19 16:00:53 UTC) #4
Stephen White
On 2013/12/19 16:00:53, sugoi wrote: > On 2013/12/19 14:55:42, Stephen White wrote: > > Tests? ...
7 years ago (2013-12-19 16:07:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://skia-tree-status.appspot.com/cq/sugoi@chromium.org/104853005/30001
7 years ago (2013-12-19 16:09:27 UTC) #6
commit-bot: I haz the power
7 years ago (2013-12-19 17:00:49 UTC) #7
Message was sent while issue was closed.
Change committed as 12773

Powered by Google App Engine
This is Rietveld 408576698