Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(655)

Unified Diff: net/quic/congestion_control/tcp_cubic_sender.cc

Issue 1048493002: Remove the using_pacing argument from QuicSentPacketManager::SetFromConfig because it's always true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/congestion_control/tcp_cubic_sender.cc
diff --git a/net/quic/congestion_control/tcp_cubic_sender.cc b/net/quic/congestion_control/tcp_cubic_sender.cc
index e89666cb212233e63e8592a3eb4a6b5d0f65648f..6e5cd729134199a5d3b2b8ba2053f7ae326d0634 100644
--- a/net/quic/congestion_control/tcp_cubic_sender.cc
+++ b/net/quic/congestion_control/tcp_cubic_sender.cc
@@ -49,6 +49,9 @@ TcpCubicSender::TcpCubicSender(const QuicClock* clock,
last_cutback_exited_slowstart_(false),
max_tcp_congestion_window_(max_tcp_congestion_window),
clock_(clock) {
+ // Disable the ack train mode in hystart when pacing is enabled, since it
+ // may be falsely triggered.
+ hybrid_slow_start_.set_ack_train_detection(false);
}
TcpCubicSender::~TcpCubicSender() {
@@ -56,8 +59,7 @@ TcpCubicSender::~TcpCubicSender() {
}
void TcpCubicSender::SetFromConfig(const QuicConfig& config,
- Perspective perspective,
- bool using_pacing) {
+ Perspective perspective) {
if (perspective == Perspective::IS_SERVER) {
if (config.HasReceivedConnectionOptions() &&
ContainsQuicTag(config.ReceivedConnectionOptions(), kIW10)) {
@@ -69,11 +71,6 @@ void TcpCubicSender::SetFromConfig(const QuicConfig& config,
// Min CWND experiment.
min_congestion_window_ = 1;
}
- if (using_pacing) {
- // Disable the ack train mode in hystart when pacing is enabled, since it
- // may be falsely triggered.
- hybrid_slow_start_.set_ack_train_detection(false);
- }
}
}
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_sender.h ('k') | net/quic/congestion_control/tcp_cubic_sender_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698