Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(69)

Unified Diff: net/quic/congestion_control/tcp_cubic_bytes_sender.cc

Issue 1048493002: Remove the using_pacing argument from QuicSentPacketManager::SetFromConfig because it's always true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: net/quic/congestion_control/tcp_cubic_bytes_sender.cc
diff --git a/net/quic/congestion_control/tcp_cubic_bytes_sender.cc b/net/quic/congestion_control/tcp_cubic_bytes_sender.cc
index c9d71ee3bf614375f893efed9e0da22cef96b089..660848d60c4655c59f1d08ca7d1835be05c96c6b 100644
--- a/net/quic/congestion_control/tcp_cubic_bytes_sender.cc
+++ b/net/quic/congestion_control/tcp_cubic_bytes_sender.cc
@@ -49,14 +49,16 @@ TcpCubicBytesSender::TcpCubicBytesSender(
slowstart_threshold_(std::numeric_limits<uint64>::max()),
last_cutback_exited_slowstart_(false),
clock_(clock) {
+ // Disable the ack train mode in hystart when pacing is enabled, since it
+ // may be falsely triggered.
+ hybrid_slow_start_.set_ack_train_detection(false);
}
TcpCubicBytesSender::~TcpCubicBytesSender() {
}
void TcpCubicBytesSender::SetFromConfig(const QuicConfig& config,
- Perspective perspective,
- bool using_pacing) {
+ Perspective perspective) {
if (perspective == Perspective::IS_SERVER) {
if (config.HasReceivedConnectionOptions() &&
ContainsQuicTag(config.ReceivedConnectionOptions(), kIW10)) {
@@ -68,11 +70,6 @@ void TcpCubicBytesSender::SetFromConfig(const QuicConfig& config,
// Min CWND experiment.
min_congestion_window_ = kMaxSegmentSize;
}
- if (using_pacing) {
- // Disable the ack train mode in hystart when pacing is enabled, since it
- // may be falsely triggered.
- hybrid_slow_start_.set_ack_train_detection(false);
- }
}
}
« no previous file with comments | « net/quic/congestion_control/tcp_cubic_bytes_sender.h ('k') | net/quic/congestion_control/tcp_cubic_bytes_sender_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698