Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(133)

Side by Side Diff: net/quic/quic_sent_packet_manager.cc

Issue 1048493002: Remove the using_pacing argument from QuicSentPacketManager::SetFromConfig because it's always true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2013 The Chromium Authors. All rights reserved. 1 // Copyright 2013 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_sent_packet_manager.h" 5 #include "net/quic/quic_sent_packet_manager.h"
6 6
7 #include <algorithm> 7 #include <algorithm>
8 8
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/stl_util.h" 10 #include "base/stl_util.h"
(...skipping 155 matching lines...) Expand 10 before | Expand all | Expand 10 after
166 } 166 }
167 if (config.HasReceivedSocketReceiveBuffer()) { 167 if (config.HasReceivedSocketReceiveBuffer()) {
168 receive_buffer_bytes_ = 168 receive_buffer_bytes_ =
169 max(kMinSocketReceiveBuffer, 169 max(kMinSocketReceiveBuffer,
170 static_cast<QuicByteCount>(config.ReceivedSocketReceiveBuffer())); 170 static_cast<QuicByteCount>(config.ReceivedSocketReceiveBuffer()));
171 if (FLAGS_quic_limit_max_cwnd_to_receive_buffer) { 171 if (FLAGS_quic_limit_max_cwnd_to_receive_buffer) {
172 send_algorithm_->SetMaxCongestionWindow(receive_buffer_bytes_ * 172 send_algorithm_->SetMaxCongestionWindow(receive_buffer_bytes_ *
173 kUsableRecieveBufferFraction); 173 kUsableRecieveBufferFraction);
174 } 174 }
175 } 175 }
176 send_algorithm_->SetFromConfig(config, perspective_, using_pacing_); 176 send_algorithm_->SetFromConfig(config, perspective_);
177 177
178 if (network_change_visitor_ != nullptr) { 178 if (network_change_visitor_ != nullptr) {
179 network_change_visitor_->OnCongestionWindowChange(); 179 network_change_visitor_->OnCongestionWindowChange();
180 } 180 }
181 } 181 }
182 182
183 bool QuicSentPacketManager::ResumeConnectionState( 183 bool QuicSentPacketManager::ResumeConnectionState(
184 const CachedNetworkParameters& cached_network_params, 184 const CachedNetworkParameters& cached_network_params,
185 bool max_bandwidth_resumption) { 185 bool max_bandwidth_resumption) {
186 if (cached_network_params.has_min_rtt_ms()) { 186 if (cached_network_params.has_min_rtt_ms()) {
(...skipping 780 matching lines...) Expand 10 before | Expand all | Expand 10 after
967 // Set up a pacing sender with a 1 millisecond alarm granularity, the same as 967 // Set up a pacing sender with a 1 millisecond alarm granularity, the same as
968 // the default granularity of the Linux kernel's FQ qdisc. 968 // the default granularity of the Linux kernel's FQ qdisc.
969 using_pacing_ = true; 969 using_pacing_ = true;
970 send_algorithm_.reset( 970 send_algorithm_.reset(
971 new PacingSender(send_algorithm_.release(), 971 new PacingSender(send_algorithm_.release(),
972 QuicTime::Delta::FromMilliseconds(1), 972 QuicTime::Delta::FromMilliseconds(1),
973 kInitialUnpacedBurst)); 973 kInitialUnpacedBurst));
974 } 974 }
975 975
976 } // namespace net 976 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_http_stream_test.cc ('k') | net/quic/quic_sent_packet_manager_test.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698