Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(317)

Side by Side Diff: net/quic/quic_http_stream_test.cc

Issue 1048493002: Remove the using_pacing argument from QuicSentPacketManager::SetFromConfig because it's always true. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 5 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "net/quic/quic_http_stream.h" 5 #include "net/quic/quic_http_stream.h"
6 6
7 #include <vector> 7 #include <vector>
8 8
9 #include "net/base/chunked_upload_data_stream.h" 9 #include "net/base/chunked_upload_data_stream.h"
10 #include "net/base/elements_upload_data_stream.h" 10 #include "net/base/elements_upload_data_stream.h"
(...skipping 178 matching lines...) Expand 10 before | Expand all | Expand 10 after
189 EXPECT_CALL(*send_algorithm_, 189 EXPECT_CALL(*send_algorithm_,
190 OnPacketSent(_, _, _, _, _)).WillRepeatedly(Return(true)); 190 OnPacketSent(_, _, _, _, _)).WillRepeatedly(Return(true));
191 EXPECT_CALL(*send_algorithm_, RetransmissionDelay()).WillRepeatedly( 191 EXPECT_CALL(*send_algorithm_, RetransmissionDelay()).WillRepeatedly(
192 Return(QuicTime::Delta::Zero())); 192 Return(QuicTime::Delta::Zero()));
193 EXPECT_CALL(*send_algorithm_, GetCongestionWindow()).WillRepeatedly( 193 EXPECT_CALL(*send_algorithm_, GetCongestionWindow()).WillRepeatedly(
194 Return(kMaxPacketSize)); 194 Return(kMaxPacketSize));
195 EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _)). 195 EXPECT_CALL(*send_algorithm_, TimeUntilSend(_, _, _)).
196 WillRepeatedly(Return(QuicTime::Delta::Zero())); 196 WillRepeatedly(Return(QuicTime::Delta::Zero()));
197 EXPECT_CALL(*send_algorithm_, BandwidthEstimate()).WillRepeatedly( 197 EXPECT_CALL(*send_algorithm_, BandwidthEstimate()).WillRepeatedly(
198 Return(QuicBandwidth::Zero())); 198 Return(QuicBandwidth::Zero()));
199 EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _, _)).Times(AnyNumber()); 199 EXPECT_CALL(*send_algorithm_, SetFromConfig(_, _)).Times(AnyNumber());
200 helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_, 200 helper_.reset(new QuicConnectionHelper(runner_.get(), &clock_,
201 &random_generator_)); 201 &random_generator_));
202 TestPacketWriterFactory writer_factory(socket); 202 TestPacketWriterFactory writer_factory(socket);
203 connection_ = new TestQuicConnection(SupportedVersions(GetParam()), 203 connection_ = new TestQuicConnection(SupportedVersions(GetParam()),
204 connection_id_, peer_addr_, 204 connection_id_, peer_addr_,
205 helper_.get(), writer_factory); 205 helper_.get(), writer_factory);
206 connection_->set_visitor(&visitor_); 206 connection_->set_visitor(&visitor_);
207 connection_->SetSendAlgorithm(send_algorithm_); 207 connection_->SetSendAlgorithm(send_algorithm_);
208 session_.reset(new QuicClientSession( 208 session_.reset(new QuicClientSession(
209 connection_, scoped_ptr<DatagramClientSocket>(socket), nullptr, 209 connection_, scoped_ptr<DatagramClientSocket>(socket), nullptr,
(...skipping 541 matching lines...) Expand 10 before | Expand all | Expand 10 after
751 // Set Delegate to nullptr and make sure EffectivePriority returns highest 751 // Set Delegate to nullptr and make sure EffectivePriority returns highest
752 // priority. 752 // priority.
753 reliable_stream->SetDelegate(nullptr); 753 reliable_stream->SetDelegate(nullptr);
754 DCHECK_EQ(QuicWriteBlockedList::kHighestPriority, 754 DCHECK_EQ(QuicWriteBlockedList::kHighestPriority,
755 reliable_stream->EffectivePriority()); 755 reliable_stream->EffectivePriority());
756 reliable_stream->SetDelegate(delegate); 756 reliable_stream->SetDelegate(delegate);
757 } 757 }
758 758
759 } // namespace test 759 } // namespace test
760 } // namespace net 760 } // namespace net
OLDNEW
« no previous file with comments | « net/quic/quic_connection_test.cc ('k') | net/quic/quic_sent_packet_manager.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698