content/browser/frame_host/navigator_impl_unittest.cc - Issue 1048463004: PlzNavigate: track pending commits

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/browser/frame_host/navigator_impl_unittest.cc

Issue 1048463004: PlzNavigate: track pending commits (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed comments + rebase on top of 1088933003 Created 5 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/browser/frame_host/navigator_impl_unittest.cc

diff --git a/content/browser/frame_host/navigator_impl_unittest.cc b/content/browser/frame_host/navigator_impl_unittest.cc

index f8069f526fb74391a0d02ab6efb8e9ed30a98633..98003844957d752ca30011baa817e9e9f9db08e9 100644

--- a/content/browser/frame_host/navigator_impl_unittest.cc

+++ b/content/browser/frame_host/navigator_impl_unittest.cc

@@ -432,6 +432,7 @@ TEST_F(NavigatorTestWithBrowserSideNavigation, CrossSiteNavigation) {

// Receive the beforeUnload ACK.

main_test_rfh()->SendBeforeUnloadACK(true);

EXPECT_TRUE(GetSpeculativeRenderFrameHost(node));

+ EXPECT_FALSE(contents()->CrossProcessNavigationPending());

scoped_refptr<ResourceResponse> response(new ResourceResponse);

GetLoaderForNavigationRequest(main_request)->CallOnResponseStarted(

@@ -440,6 +441,7 @@ TEST_F(NavigatorTestWithBrowserSideNavigation, CrossSiteNavigation) {

ASSERT_TRUE(speculative_rfh);

EXPECT_TRUE(DidRenderFrameHostRequestCommit(speculative_rfh));

EXPECT_FALSE(DidRenderFrameHostRequestCommit(main_test_rfh()));

+ EXPECT_TRUE(contents()->CrossProcessNavigationPending());

speculative_rfh->SendNavigate(0, kUrl2);