PlzNavigate: track pending commits

content/test/test_web_contents.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_TEST_TEST_WEB_CONTENTS_H_
 #define CONTENT_TEST_TEST_WEB_CONTENTS_H_
 
 #include "content/browser/web_contents/web_contents_impl.h"
 #include "content/public/test/web_contents_tester.h"
 #include "content/test/test_render_frame_host.h"
@@ skipping 30 matching lines @@
   void TestDidNavigate(RenderFrameHost* render_frame_host,
                        int page_id,
                        const GURL& url,
                        ui::PageTransition transition) override;
   void TestDidNavigateWithReferrer(RenderFrameHost* render_frame_host,
                                    int page_id,
                                    const GURL& url,
                                    const Referrer& referrer,
                                    ui::PageTransition transition) override;
 
-  // State accessor.
-  bool cross_navigation_pending() {
-    return GetRenderManager()->cross_navigation_pending_;
-  }
+  // True if a cross-site navigation is pending.
+  bool CrossNavigationPending();

[nasko, 2015/04/15 21:12:46]

Shouldn't it be CrossSiteNavigationPending, since the navigation is cross-site,
not just "cross"?

[Charlie Reis, 2015/04/15 21:54:17]

Yes, as long as we're updating the name, please fix this.  (It's always bothered
me.)  I think CrossProcessNavigationPending is probably better, since not all
cross-site navigations are cross-process.  (Technically it could end up in a new
SiteInstance but the same RenderProcessHost, but that's splitting hairs.)

(As I mentioned separately, I'll remove that cross_navigation_pending_ member
once this CL lands.)

[clamy, 2015/04/16 13:18:36]

Done.

 
   // Prevent interaction with views.
   bool CreateRenderViewForRenderManager(RenderViewHost* render_view_host,
                                         int opener_route_id,
                                         int proxy_routing_id,
                                         bool for_main_frame) override;
   void UpdateRenderViewSizeForRenderManager() override {}
 
   // Returns a clone of this TestWebContents. The returned object is also a
   // TestWebContents. The caller owns the returned object.
@@ skipping 54 matching lines @@
 
   // Expectations for arguments of |SetHistoryOffsetAndLength()|.
   bool expect_set_history_offset_and_length_;
   int expect_set_history_offset_and_length_history_offset_;
   int expect_set_history_offset_and_length_history_length_;
 };
 
 }  // namespace content
 
 #endif  // CONTENT_TEST_TEST_WEB_CONTENTS_H_