PlzNavigate: track pending commits

content/browser/frame_host/render_frame_host_manager.h

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
 #define CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_
 
 #include <list>
 
 #include "base/basictypes.h"
@@ skipping 371 matching lines @@
 
   // PlzNavigate
   // Notifies the RFHM that a navigation has begun so that it can speculatively
   // create a new RenderFrameHost (and potentially a new process) if needed.
   void BeginNavigation(const NavigationRequest& request);
 
   // PlzNavigate
   // Called (possibly several times) during a navigation to select or create an
   // appropriate RenderFrameHost for the provided URL. The returned pointer will
   // be for the current or the speculative RenderFrameHost and the instance is
-  // owned by this manager.
+  // owned by this manager. ¬for_commit¬ is true if it is the final call in the

[nasko, 2015/03/30 22:35:22]

nit: The characters around "for_commit" aren't something that displays correctly
here. Are you using quotes or pipes for it?

+  // navigation, and the renderer selected will commit the navigation.
   RenderFrameHostImpl* GetFrameHostForNavigation(
-      const NavigationRequest& request);
+      const NavigationRequest& request,
+      bool for_commit);
 
   // PlzNavigate
   // Clean up any state for any ongoing navigation.
   void CleanUpNavigation();
 
   // PlzNavigate
   // Clears the speculative members, returning the RenderFrameHost to the caller
   // for disposal.
   scoped_ptr<RenderFrameHostImpl> UnsetSpeculativeRenderFrameHost();
 
@@ skipping 209 matching lines @@
 
   // For use in creating RenderFrameHosts.
   FrameTreeNode* frame_tree_node_;
 
   // Our delegate, not owned by us. Guaranteed non-NULL.
   Delegate* delegate_;
 
   // Whether a navigation requiring different RenderFrameHosts is pending. This
   // is either for cross-site requests or when required for the process type
   // (like WebUI).
-  // PlzNavigate: |cross_navigation_pending_| is not used for browser-side
+  // PlzNavigate: |cross_navigation_pending_| is used to signal that the
+  // speculative_render_frame_host_ is in the process of committing the
   // navigation.
   bool cross_navigation_pending_;
 
   // Implemented by the owner of this class.  These delegates are installed into
   // all the RenderFrameHosts that we create.
   RenderFrameHostDelegate* render_frame_delegate_;
   RenderViewHostDelegate* render_view_delegate_;
   RenderWidgetHostDelegate* render_widget_delegate_;
 
   // Our RenderFrameHost and its associated Web UI (if any, will be NULL for
@@ skipping 68 matching lines @@
   bool should_reuse_web_ui_;
 
   base::WeakPtrFactory<RenderFrameHostManager> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderFrameHostManager);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_FRAME_HOST_RENDER_FRAME_HOST_MANAGER_H_