Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2740)

Unified Diff: android_webview/android_webview.gyp

Issue 1048463003: Use jinja2 to template webview manifest files. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Simplify intermediate dir Created 5 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | android_webview/apk/java/AndroidManifest.xml » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: android_webview/android_webview.gyp
diff --git a/android_webview/android_webview.gyp b/android_webview/android_webview.gyp
index f20c3be27b995af7f04e2e62a32e17df39b7be2f..72333881fa4a1ccc9dcf71eda013b3eb67625a1b 100644
--- a/android_webview/android_webview.gyp
+++ b/android_webview/android_webview.gyp
@@ -388,11 +388,17 @@
'variables': {
'apk_name': 'SystemWebView',
'android_sdk_jar': '../third_party/android_platform/webview/frameworks_5.1.0_r1.jar',
- 'android_manifest_path': 'apk/java/AndroidManifest.xml',
+ 'jinja_inputs': ['apk/java/AndroidManifest.xml'],
Torne 2015/03/30 13:31:09 Thinking about it more, all this logic should go i
Tobias Sargeant 2015/03/30 13:53:07 Done.
+ 'jinja_output': '<(INTERMEDIATE_DIR)/AndroidManifest.xml',
+ 'jinja_variables': [ ],
+ 'android_manifest_path': '<(INTERMEDIATE_DIR)/AndroidManifest.xml',
'java_in_dir': 'glue/java',
'resource_dir': 'apk/java/res',
},
- 'includes': [ 'apk/system_webview_apk_common.gypi' ],
+ 'includes': [
+ 'apk/system_webview_apk_common.gypi',
+ '../build/android/jinja_template.gypi',
+ ],
},
],
}, { # android_webview_build==1
« no previous file with comments | « no previous file | android_webview/apk/java/AndroidManifest.xml » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698