Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(86)

Issue 1048423003: Make SkPngCodec support rewinding properly. (Closed)

Created:
5 years, 8 months ago by scroggo
Modified:
5 years, 8 months ago
Reviewers:
msarett, hal.canary
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@master
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Make SkPngCodec support rewinding properly. Separate out the code for reading the header, and use it to reinitialize fPng_ptr and fInfo_ptr after a rewind. Use common code to clean up fPng_ptr and fInfo_ptr, and set them to NULL and treat them as NULL as appropriate. Update the test to expect SkPngCodec to succeed. BUG=skia:3257 Committed: https://skia.googlesource.com/skia/+/3eada2a49ff2814833afcbd61329aa451d86da9c

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -26 lines) Patch
M src/codec/SkCodec_libpng.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/codec/SkCodec_libpng.cpp View 6 chunks +57 lines, -12 lines 0 comments Download
M tests/CodexTest.cpp View 1 chunk +13 lines, -14 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
scroggo
5 years, 8 months ago (2015-04-01 13:01:52 UTC) #2
msarett
lgtm I don't want to hold this up any longer, but it might be good ...
5 years, 8 months ago (2015-04-01 15:58:37 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048423003/1
5 years, 8 months ago (2015-04-01 16:28:22 UTC) #5
commit-bot: I haz the power
5 years, 8 months ago (2015-04-01 16:33:29 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/3eada2a49ff2814833afcbd61329aa451d86da9c

Powered by Google App Engine
This is Rietveld 408576698