Issue 1048383002: [SkDebugger] Flatten drawPicture ops

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1048383002: [SkDebugger] Flatten drawPicture ops (Closed)

Created:
5 years, 8 months ago by f(malita)

Modified:
5 years, 8 months ago

Reviewers:
Pan, mtklein, Stephen Chennney, robertphillips

CC:
reviews_skia.org

Base URL:
https://chromium.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

[SkDebugger] Flatten drawPicture ops Add two drawPicture bracketing ops (BeginDrawPicture, EndDrawPicture) to replace the current DrawPicture op, and flatten picture contents. Committed: https://skia.googlesource.com/skia/+/160ebb2bfa0794d72d31a786793b13413289863d

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+73 lines, -35 lines)			Patch
M	debugger/QT/SkDebuggerGUI.cpp	View	3 chunks	+8 lines, -3 lines	0 comments	Download
M	src/utils/debugger/SkDebugCanvas.cpp	View	1 chunk	+3 lines, -1 line	0 comments	Download
M	src/utils/debugger/SkDrawCommand.h	View	4 chunks	+21 lines, -7 lines	0 comments	Download
M	src/utils/debugger/SkDrawCommand.cpp	View	5 chunks	+41 lines, -24 lines	0 comments	Download

Total messages: 6 (2 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048383002/1

5 years, 8 months ago (2015-04-02 03:53:06 UTC) #5

commit-bot: I haz the power

5 years, 8 months ago (2015-04-02 03:58:42 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/160ebb2bfa0794d72d31a786793b13413289863d