Autofill: Recognize more credit card date fields.

components/autofill/core/browser/credit_card_field.cc

Index: components/autofill/core/browser/credit_card_field.cc
diff --git a/components/autofill/core/browser/credit_card_field.cc b/components/autofill/core/browser/credit_card_field.cc
index 07826a106d0cbc262b75207e700152a360854b96..7142324ca2c0e3595b80faa32a91e5a625254e8c 100644
--- a/components/autofill/core/browser/credit_card_field.cc
+++ b/components/autofill/core/browser/credit_card_field.cc
@@ -50,6 +50,28 @@ bool FindConsecutiveStrings(const std::vector<base::string16>& regex_needles,
   return false;
 }
 
+// Returns true if a field that has |max_length| can fit the data for a field of
+// |type|.
+bool FieldCanFitDataForFieldType(int max_length, ServerFieldType type) {
+  if (max_length == 0)
+    return true;
+
+  switch (type) {
+    case CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR: {
+      static int kMinimum2YearCcExpLength = strlen("12/14");
+      return max_length >= kMinimum2YearCcExpLength;
+    }
+    case CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR: {
+      static int kMinimum4YearCcExpLength = strlen("12/2014");
+      return max_length >= kMinimum4YearCcExpLength;
+    }
+    default:
+      NOTREACHED();
+      return false;
+  }
+}
+
+
 }  // namespace
 
 // static
@@ -359,39 +381,59 @@ bool CreditCardField::ParseExpirationDate(AutofillScanner* scanner) {
   }
 
   // If that fails, try to parse a combined expiration field.
-  // Look for a 2-digit year first.
   // We allow <select> fields, because they're used e.g. on qvc.com.
   scanner->RewindTo(month_year_saved_cursor);
 
-  static int kMinimum2YearCcExpLength = strlen("12/14");
-  int current_field_max_length = scanner->Cursor()->max_length;
-  if (current_field_max_length > 0 &&
-      current_field_max_length < kMinimum2YearCcExpLength) {
+  // Bail out if the field cannot fit a 2-digit year expiration date.
+  const int current_field_max_length = scanner->Cursor()->max_length;
+  if (!FieldCanFitDataForFieldType(current_field_max_length,
+                                   CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR)) {
     return false;
   }
 
+  // Try to look for a 2-digit year expiration date. The second
+  // ParseFieldSpecifics() call is separate to make it clearer what it is
+  // trying to match.

[Evan Stade, 2015/04/03 02:04:57]

This logic confuses me. I think they should be one regex.

   if (ParseFieldSpecifics(scanner,
                           base::UTF8ToUTF16(kExpirationDate2DigitYearRe),
                           kMatchTelAndSelect,
+                          &expiration_date_) ||
+      ParseFieldSpecifics(scanner,
+                          base::ASCIIToUTF16("^mm\\s*[-/]\\syy$"),
+                          kMatchTelAndSelect,
                           &expiration_date_)) {
     exp_year_type_ = CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR;
     expiration_month_ = nullptr;
     return true;
   }
 
+  // Try to look for a generic expiration date field. (2 or 4 digit year)
   if (ParseFieldSpecifics(scanner,
                           base::UTF8ToUTF16(kExpirationDateRe),
                           kMatchTelAndSelect,
                           &expiration_date_)) {
-    static int kMinimum4YearCcExpLength = strlen("12/2014");
-    if (current_field_max_length > 0 &&
-        current_field_max_length < kMinimum4YearCcExpLength) {
+    // If such a field exists, bit it cannot fit a 4-digit year expiration

[Evan Stade, 2015/04/03 02:04:57]

s/bit/but

+    // date, then the likely possibility is that it is a 2-digit year expiration
+    // date.
+    if (!FieldCanFitDataForFieldType(current_field_max_length,
+                                     CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR)) {
       exp_year_type_ = CREDIT_CARD_EXP_DATE_2_DIGIT_YEAR;
     }
     expiration_month_ = nullptr;
     return true;
   }
 
+  // Try to look for a 4-digit year expiration date.
+  if (FieldCanFitDataForFieldType(current_field_max_length,
+                                  CREDIT_CARD_EXP_DATE_4_DIGIT_YEAR) &&
+      ParseFieldSpecifics(scanner,
+                          base::ASCIIToUTF16("^mm\\s*[-/]\\syyyy$"),

[Evan Stade, 2015/04/03 02:04:57]

I think this can go in the utf8 file. mm/yyyy is English specific.

+                          kMatchTelAndSelect,
+                          &expiration_date_)) {
+    expiration_month_ = nullptr;
+    return true;
+  }
+
   return false;
 }