Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1048363002: Autofill: Recognize more credit card date fields. (Closed)

Created:
5 years, 8 months ago by Lei Zhang
Modified:
5 years, 8 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, estade+watch_chromium.org, browser-components-watch_chromium.org, rouslan+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@autofill_exp
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Autofill: Recognize more credit card date fields. BUG=471831 Committed: https://crrev.com/49946212049e5744449e5222de7d1d114de97e9d Cr-Commit-Position: refs/heads/master@{#323853}

Patch Set 1 #

Total comments: 4

Patch Set 2 : rebase #

Patch Set 3 : #

Total comments: 3

Patch Set 4 : #

Total comments: 2

Patch Set 5 : nit, rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+182 lines, -11 lines) Patch
A chrome/test/data/autofill/heuristics/input/bug_471831.html View 1 2 1 chunk +95 lines, -0 lines 0 comments Download
A chrome/test/data/autofill/heuristics/output/bug_471831.out View 1 2 1 chunk +7 lines, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.h View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M components/autofill/core/browser/autofill_regex_constants.cc.utf8 View 1 2 3 4 1 chunk +4 lines, -3 lines 0 comments Download
M components/autofill/core/browser/credit_card_field.cc View 1 2 3 4 3 chunks +44 lines, -8 lines 0 comments Download
M components/autofill/core/browser/credit_card_field_unittest.cc View 1 chunk +31 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (3 generated)
Lei Zhang
Applies on top of https://codereview.chromium.org/1053473002/
5 years, 8 months ago (2015-04-01 03:29:22 UTC) #2
Evan Stade
https://codereview.chromium.org/1048363002/diff/1/components/autofill/core/browser/credit_card_field.cc File components/autofill/core/browser/credit_card_field.cc (right): https://codereview.chromium.org/1048363002/diff/1/components/autofill/core/browser/credit_card_field.cc#newcode379 components/autofill/core/browser/credit_card_field.cc:379: base::ASCIIToUTF16("^mm\\s*[-/]\\syy$"), can you add comment explaining why this isn't ...
5 years, 8 months ago (2015-04-01 23:11:30 UTC) #3
Lei Zhang
Also added a browser test. https://codereview.chromium.org/1048363002/diff/1/components/autofill/core/browser/credit_card_field.cc File components/autofill/core/browser/credit_card_field.cc (right): https://codereview.chromium.org/1048363002/diff/1/components/autofill/core/browser/credit_card_field.cc#newcode379 components/autofill/core/browser/credit_card_field.cc:379: base::ASCIIToUTF16("^mm\\s*[-/]\\syy$"), On 2015/04/01 23:11:29, ...
5 years, 8 months ago (2015-04-03 02:02:01 UTC) #4
Evan Stade
https://codereview.chromium.org/1048363002/diff/40001/components/autofill/core/browser/credit_card_field.cc File components/autofill/core/browser/credit_card_field.cc (right): https://codereview.chromium.org/1048363002/diff/40001/components/autofill/core/browser/credit_card_field.cc#newcode396 components/autofill/core/browser/credit_card_field.cc:396: // trying to match. This logic confuses me. I ...
5 years, 8 months ago (2015-04-03 02:04:57 UTC) #5
Lei Zhang
See patch set 4.
5 years, 8 months ago (2015-04-03 05:42:00 UTC) #7
Evan Stade
mostly lg https://codereview.chromium.org/1048363002/diff/80001/components/autofill/core/browser/autofill_regex_constants.cc.utf8 File components/autofill/core/browser/autofill_regex_constants.cc.utf8 (right): https://codereview.chromium.org/1048363002/diff/80001/components/autofill/core/browser/autofill_regex_constants.cc.utf8#newcode189 components/autofill/core/browser/autofill_regex_constants.cc.utf8:189: "|exp.*date.*[^y]yy([^y]|$)"; ^mm\\s*[-/]\\syy$ seems a bit too specific ...
5 years, 8 months ago (2015-04-03 20:07:00 UTC) #8
Lei Zhang
https://codereview.chromium.org/1048363002/diff/80001/components/autofill/core/browser/autofill_regex_constants.cc.utf8 File components/autofill/core/browser/autofill_regex_constants.cc.utf8 (right): https://codereview.chromium.org/1048363002/diff/80001/components/autofill/core/browser/autofill_regex_constants.cc.utf8#newcode189 components/autofill/core/browser/autofill_regex_constants.cc.utf8:189: "|exp.*date.*[^y]yy([^y]|$)"; On 2015/04/03 20:07:00, Evan Stade wrote: > ^mm\\s*[-/]\\syy$ ...
5 years, 8 months ago (2015-04-03 22:37:33 UTC) #9
Evan Stade
lgtm
5 years, 8 months ago (2015-04-03 22:50:22 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048363002/100001
5 years, 8 months ago (2015-04-03 22:55:57 UTC) #12
commit-bot: I haz the power
Committed patchset #5 (id:100001)
5 years, 8 months ago (2015-04-04 00:00:09 UTC) #13
commit-bot: I haz the power
5 years, 8 months ago (2015-04-04 00:01:01 UTC) #14
Message was sent while issue was closed. 
Patchset 5 (id:??) landed as
https://crrev.com/49946212049e5744449e5222de7d1d114de97e9d
Cr-Commit-Position: refs/heads/master@{#323853}

Powered by Google App Engine
This is Rietveld 408576698