Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(283)

Issue 1048343002: Enable the views-based AppInfoDialog on Mac (Closed)

Created:
5 years, 8 months ago by tapted
Modified:
5 years, 7 months ago
Reviewers:
benwells
CC:
chromium-reviews, tfarina, chrome-apps-syd-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@20150330-MacViews-EnableAppList-PLUS-mac-views-browser
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Enable the views-based AppInfoDialog on Mac There's an expected ~443kB sizes regression in ChromiumFramework with this. This is because large portions of views.dylib are still culled at link time with -dead_strip, but this CL makes more symbols reachable. For a full accounting see http://crbug.com/485854#c1 (nothing unexpected). The dialog is enabled by linking in app_info_dialog_views.cc to provide functions previously provided (but NOTIMPLEMENTED()) by app_info_dialog_cocoa.mm. Note that the views CanShowAppInfoDialog() is implemented as IsMacViewsAppListListEnabled(), so no user-visible changes occur unless Chrome is run from the command line with --enable-mac-views-app-list. With this flag, the `Details` link at chrome://extensions will show the views-based (and offline-enabled) AppInfo dialog rather than taking the user to the webstore URL. And the context menu for icons at chrome://apps will have an `App Info` option. (Note that the views-based App Launcher isn't currently linked in on Mac, so the app launcher shown with --enable-mac-views-app-list --show-app-list doesn't support this dialog yet). Screenshot at http://crbug.com/485854#c2 BUG=485854 Committed: https://crrev.com/99e8dd40da33d58d598b000e122939b04272c079 Cr-Commit-Position: refs/heads/master@{#329362}

Patch Set 1 #

Patch Set 2 : scrap app_info_dialog_cocoa.mm #

Patch Set 3 : Rebase to master #

Patch Set 4 : rebase #

Patch Set 5 : rebase. again? really? #

Patch Set 6 : double-check now that r329097 landed #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -46 lines) Patch
M chrome/browser/ui/cocoa/apps/app_info_dialog_cocoa.mm View 1 1 chunk +0 lines, -33 lines 0 comments Download
M chrome/chrome_browser_ui.gypi View 1 2 3 4 3 chunks +12 lines, -13 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
tapted
Hi Ben, please take a look
5 years, 7 months ago (2015-05-11 07:29:37 UTC) #3
benwells
lgtm. no, lrrrrrgtm! (looks really really really really really good to me)
5 years, 7 months ago (2015-05-12 03:17:43 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1048343002/120001
5 years, 7 months ago (2015-05-12 06:17:25 UTC) #6
commit-bot: I haz the power
Committed patchset #6 (id:120001)
5 years, 7 months ago (2015-05-12 06:22:58 UTC) #7
commit-bot: I haz the power
Patchset 6 (id:??) landed as https://crrev.com/99e8dd40da33d58d598b000e122939b04272c079 Cr-Commit-Position: refs/heads/master@{#329362}
5 years, 7 months ago (2015-05-12 06:23:42 UTC) #8
tapted
5 years, 7 months ago (2015-05-12 07:21:07 UTC) #9
Message was sent while issue was closed.
Filed perf bug at http://crbug.com/487106 for the sizes regression with link to
graphs, etc. It actually came out a bit smaller than I was expecting (229kB).

Powered by Google App Engine
This is Rietveld 408576698