Issue 1048333006: Fix getChildElements.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1048333006: Fix getChildElements. (Closed)

Created:
5 years, 8 months ago by ojan

Modified:
5 years, 8 months ago

Reviewers:
eseidel

CC:
abarth-chromium, mojo-reviews_chromium.org, qsr+mojo_chromium.org

Base URL:
https://github.com/domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

Fix getChildElements. It was returing all element descendants instead of all element immediate children. R=eseidel@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2b44d8c1bd8976733e7f1942d7619087e7c837f1

Created: 5 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+28 lines, -2 lines)			Patch
M	sky/engine/core/dom/ContainerNode.cpp	View	1 chunk	+1 line, -1 line	0 comments	Download
A	sky/tests/dom/getChildElements.sky	View	1 chunk	+26 lines, -0 lines	0 comments	Download
A +	sky/tests/dom/getChildElements-expected.txt	View	1 chunk	+1 line, -1 line	0 comments	Download

Total messages: 3 (1 generated)

ojan

5 years, 8 months ago (2015-04-14 23:41:02 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2b44d8c1bd8976733e7f1942d7619087e7c837f1 (presubmit successful).